closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)

Reported by Svace static analyzer.

closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl() (GH-8872)
Reported by Svace static analyzer.
2b824b25 · Alexey Izbyshev · Benjamin Peterson · f6247aac · 2b824b25
Commit 2b824b25 authored Aug 24, 2018 by Alexey Izbyshev Committed by Benjamin Peterson Aug 23, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 0 deletions

Python/bltinmodule.c Python/bltinmodule.c +5 -0

No files found.
--- a/Python/bltinmodule.c
+++ b/Python/bltinmodule.c
@@ -2401,6 +2401,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                }
            }
            result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
            temp = PyNumber_Add(result, item);
            Py_DECREF(result);
            Py_DECREF(item);