Issue #19255: Clear error after failed PyDict_SetItem() on shutdown.

This silences a Coverity complain.

Issue #19255: Clear error after failed PyDict_SetItem() on shutdown.
This silences a Coverity complain.
2d6d0b5d · Serhiy Storchaka · 6382c5fe · 2d6d0b5d
Commit 2d6d0b5d authored Feb 12, 2014 by Serhiy Storchaka
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

Objects/moduleobject.c Objects/moduleobject.c +4 -2

No files found.
--- a/Objects/moduleobject.c
+++ b/Objects/moduleobject.c
@@ -330,7 +330,8 @@ _PyModule_ClearDict(PyObject *d)
                    else
                        PyErr_Clear();
                }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
            }
        }
    }
@@ -349,7 +350,8 @@ _PyModule_ClearDict(PyObject *d)
                    else
                        PyErr_Clear();
                }
-                PyDict_SetItem(d, key, Py_None);
+                if (PyDict_SetItem(d, key, Py_None) != 0)
+                    PyErr_Clear();
            }
        }
    }