Commit 2eed8b7d authored by Yury Selivanov's avatar Yury Selivanov

inspect.getfile: Don't crash on classes without '__module__' attribute #20372

Some classes defined in C may not have the '__module__' attribute, so
we now handle this case to avoid having unexepected AttributeError.
parent 32970b8d
...@@ -516,9 +516,10 @@ def getfile(object): ...@@ -516,9 +516,10 @@ def getfile(object):
return object.__file__ return object.__file__
raise TypeError('{!r} is a built-in module'.format(object)) raise TypeError('{!r} is a built-in module'.format(object))
if isclass(object): if isclass(object):
object = sys.modules.get(object.__module__) if hasattr(object, '__module__'):
if hasattr(object, '__file__'): object = sys.modules.get(object.__module__)
return object.__file__ if hasattr(object, '__file__'):
return object.__file__
raise TypeError('{!r} is a built-in class'.format(object)) raise TypeError('{!r} is a built-in class'.format(object))
if ismethod(object): if ismethod(object):
object = object.__func__ object = object.__func__
......
...@@ -319,6 +319,16 @@ class TestRetrievingSourceCode(GetSourceBase): ...@@ -319,6 +319,16 @@ class TestRetrievingSourceCode(GetSourceBase):
def test_getfile(self): def test_getfile(self):
self.assertEqual(inspect.getfile(mod.StupidGit), mod.__file__) self.assertEqual(inspect.getfile(mod.StupidGit), mod.__file__)
def test_getfile_class_without_module(self):
class CM(type):
@property
def __module__(cls):
raise AttributeError
class C(metaclass=CM):
pass
with self.assertRaises(TypeError):
inspect.getfile(C)
def test_getmodule_recursion(self): def test_getmodule_recursion(self):
from types import ModuleType from types import ModuleType
name = '__inspect_dummy' name = '__inspect_dummy'
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment