Issue #25221: Fix corrupted result from PyLong_FromLong(0) when Python is...

Issue #25221: Fix corrupted result from PyLong_FromLong(0) when Python is compiled with NSMALLPOSINTS = 0.

Issue #25221: Fix corrupted result from PyLong_FromLong(0) when Python is...
Issue #25221: Fix corrupted result from PyLong_FromLong(0) when Python is compiled with NSMALLPOSINTS = 0.
36820dd5 · Mark Dickinson · f028d9f7 · 36820dd5 · 36820dd5
Commit 36820dd5 authored Sep 10, 2016 by Mark Dickinson
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 1 deletion

Misc/NEWS Misc/NEWS +3 -0

Objects/longobject.c Objects/longobject.c +2 -1

No files found.
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -10,6 +10,9 @@ Release date: TBA
 Core and Builtins
 -----------------

+- Issue #25221: Fix corrupted result from PyLong_FromLong(0) when
+  Python is compiled with NSMALLPOSINTS = 0.
+
 - Issue #25758: Prevents zipimport from unnecessarily encoding a filename
  (patch by Eryk Sun)


--- a/Objects/longobject.c
+++ b/Objects/longobject.c
@@ -234,7 +234,7 @@ PyLong_FromLong(long ival)
    unsigned long abs_ival;
    unsigned long t;  /* unsigned so >> doesn't propagate sign bit */
    int ndigits = 0;
-    int sign = 1;
+    int sign;

    CHECK_SMALL_INT(ival);

@@ -246,6 +246,7 @@ PyLong_FromLong(long ival)
    }
    else {
        abs_ival = (unsigned long)ival;
+        sign = ival == 0 ? 0 : 1;
    }

    /* Fast path for single-digit ints */