Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
36ecd676
Commit
36ecd676
authored
Jan 29, 2010
by
Mark Dickinson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #7788: Fix a crash produced by deleting a list slice with huge
step value. Patch by Marcin Bachry.
parent
b5d7400e
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
17 additions
and
5 deletions
+17
-5
Lib/test/list_tests.py
Lib/test/list_tests.py
+3
-0
Lib/test/test_array.py
Lib/test/test_array.py
+3
-0
Lib/test/test_bytes.py
Lib/test/test_bytes.py
+1
-1
Misc/NEWS
Misc/NEWS
+3
-0
Modules/arraymodule.c
Modules/arraymodule.c
+3
-2
Objects/bytearrayobject.c
Objects/bytearrayobject.c
+2
-1
Objects/listobject.c
Objects/listobject.c
+2
-1
No files found.
Lib/test/list_tests.py
View file @
36ecd676
...
...
@@ -519,6 +519,9 @@ class CommonTest(seq_tests.CommonTest):
a
=
self
.
type2test
(
range
(
10
))
a
[::
2
]
=
tuple
(
range
(
5
))
self
.
assertEqual
(
a
,
self
.
type2test
([
0
,
1
,
1
,
3
,
2
,
5
,
3
,
7
,
4
,
9
]))
# test issue7788
a
=
self
.
type2test
(
range
(
10
))
del
a
[
9
::
1
<<
333
]
def
test_constructor_exception_handling
(
self
):
# Bug #1242657
...
...
Lib/test/test_array.py
View file @
36ecd676
...
...
@@ -882,6 +882,9 @@ class NumberTest(BaseTest):
a
=
array
.
array
(
self
.
typecode
,
range
(
10
))
del
a
[::
1000
]
self
.
assertEqual
(
a
,
array
.
array
(
self
.
typecode
,
[
1
,
2
,
3
,
4
,
5
,
6
,
7
,
8
,
9
]))
# test issue7788
a
=
array
.
array
(
self
.
typecode
,
range
(
10
))
del
a
[
9
::
1
<<
333
]
def
test_assignment
(
self
):
a
=
array
.
array
(
self
.
typecode
,
range
(
10
))
...
...
Lib/test/test_bytes.py
View file @
36ecd676
...
...
@@ -565,7 +565,7 @@ class ByteArrayTest(BaseBytesTest):
self.assertEqual(b, bytearray([0, 1, 2, 42, 42, 42, 3, 4, 5, 6, 7, 8, 9]))
def test_extended_set_del_slice(self):
indices = (0, None, 1, 3, 19, 300, -1, -2, -31, -300)
indices = (0, None, 1, 3, 19, 300,
1<<333,
-1, -2, -31, -300)
for start in indices:
for stop in indices:
# Skip invalid step 0
...
...
Misc/NEWS
View file @
36ecd676
...
...
@@ -12,6 +12,9 @@ What's New in Python 2.7 alpha 3?
Core and Builtins
-----------------
- Issue #7788: Fix an interpreter crash produced by deleting a list
slice with very large step value.
- Issue #7766: Change sys.getwindowsversion() return value to a named
tuple and add the additional members returned in an OSVERSIONINFOEX
structure. The new members are service_pack_major, service_pack_minor,
...
...
Modules/arraymodule.c
View file @
36ecd676
...
...
@@ -1792,8 +1792,9 @@ array_ass_subscr(arrayobject* self, PyObject* item, PyObject* value)
}
else
if
(
needed
==
0
)
{
/* Delete slice */
Py_ssize_t
cur
,
i
;
size_t
cur
;
Py_ssize_t
i
;
if
(
step
<
0
)
{
stop
=
start
+
1
;
start
=
stop
+
step
*
(
slicelength
-
1
)
-
1
;
...
...
Objects/bytearrayobject.c
View file @
36ecd676
...
...
@@ -691,7 +691,8 @@ bytearray_ass_subscript(PyByteArrayObject *self, PyObject *index, PyObject *valu
else
{
if
(
needed
==
0
)
{
/* Delete slice */
Py_ssize_t
cur
,
i
;
size_t
cur
;
Py_ssize_t
i
;
if
(
!
_canresize
(
self
))
return
-
1
;
...
...
Objects/listobject.c
View file @
36ecd676
...
...
@@ -2624,7 +2624,8 @@ list_ass_subscript(PyListObject* self, PyObject* item, PyObject* value)
if
(
value
==
NULL
)
{
/* delete slice */
PyObject
**
garbage
;
Py_ssize_t
cur
,
i
;
size_t
cur
;
Py_ssize_t
i
;
if
(
slicelength
<=
0
)
return
0
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment