Commit 3986d4e6 authored by Tim Peters's avatar Tim Peters

PyList_New(): we went to all the trouble of computing and bounds-checking

the size_t nbytes, and passed nbytes to malloc, so it was confusing to
effectively recompute the same thing from scratch in the memset call.
parent 6d3db700
...@@ -59,6 +59,7 @@ PyList_New(int size) ...@@ -59,6 +59,7 @@ PyList_New(int size)
{ {
PyListObject *op; PyListObject *op;
size_t nbytes; size_t nbytes;
if (size < 0) { if (size < 0) {
PyErr_BadInternalCall(); PyErr_BadInternalCall();
return NULL; return NULL;
...@@ -82,7 +83,7 @@ PyList_New(int size) ...@@ -82,7 +83,7 @@ PyList_New(int size)
op->ob_item = (PyObject **) PyMem_MALLOC(nbytes); op->ob_item = (PyObject **) PyMem_MALLOC(nbytes);
if (op->ob_item == NULL) if (op->ob_item == NULL)
return PyErr_NoMemory(); return PyErr_NoMemory();
memset(op->ob_item, 0, sizeof(*op->ob_item) * size); memset(op->ob_item, 0, nbytes);
} }
op->ob_size = size; op->ob_size = size;
op->allocated = size; op->allocated = size;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment