Commit 3a77c7ab authored by Walter Dörwald's avatar Walter Dörwald

If append mode is specified seek to the end of the file.

Add a test to test_fileio.py for this.
parent fee1af9d
......@@ -205,6 +205,24 @@ class OtherFileTests(unittest.TestCase):
finally:
os.unlink(TESTFN)
def testAppend(self):
try:
f = open(TESTFN, 'wb')
f.write(b'spam')
f.close()
f = open(TESTFN, 'ab')
f.write(b'eggs')
f.close()
f = open(TESTFN, 'rb')
d = f.read()
f.close()
self.assertEqual(d, b'spameggs')
finally:
try:
os.unlink(TESTFN)
except:
pass
def test_main():
# Historically, these tests have been sloppy about removing TESTFN.
# So get rid of it no matter what.
......
......@@ -242,6 +242,18 @@ fileio_init(PyObject *oself, PyObject *args, PyObject *kwds)
PyErr_SetFromErrnoWithFilename(PyExc_IOError, name);
goto error;
}
if (append) {
int result;
Py_BEGIN_ALLOW_THREADS
errno = 0;
result = lseek(self->fd, 0, SEEK_END);
Py_END_ALLOW_THREADS
if (result < 0) {
close(self->fd);
PyErr_SetFromErrnoWithFilename(PyExc_IOError, name);
goto error;
}
}
}
goto done;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment