bpo-25430: improve performance of IPNetwork.__contains__ (GH-1785)

make a compare in bit-operation manner.

bpo-25430: improve performance of IPNetwork.contains (GH-1785)
make a compare in bit-operation manner.
3bbcc925 · gescheit · Inada Naoki · b0a2c0fa · 3bbcc925 · 3bbcc925
Commit 3bbcc925 authored Apr 30, 2019 by gescheit Committed by Inada Naoki Apr 30, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

Lib/ipaddress.py Lib/ipaddress.py +1 -2

Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst ...S.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst +1 -0

No files found.
--- a/Lib/ipaddress.py
+++ b/Lib/ipaddress.py
@@ -697,8 +697,7 @@ class _BaseNetwork(_IPAddressBase):
        # dealing with another address
        else:
            # address
-            return (int(self.network_address) <= int(other._ip) <=
-                    int(self.broadcast_address))
+            return other._ip & self.netmask._ip == self.network_address._ip

    def overlaps(self, other):
        """Tell if self is partly contained in other."""

--- a/Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst
+++ b/Misc/NEWS.d/next/Library/2019-04-15-12-22-09.bpo-25430.7_8kqc.rst
+improve performance of ``IPNetwork.__contains__()``
\ No newline at end of file