Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
3cf74384
Commit
3cf74384
authored
Dec 08, 2018
by
Anirudha Bose
Committed by
Brett Cannon
Dec 07, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-33747: Avoid mutating the global sys.modules dict in unittest.mock tests (GH-8520)
parent
028f0ef4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
16 additions
and
11 deletions
+16
-11
Lib/unittest/test/testmock/testpatch.py
Lib/unittest/test/testmock/testpatch.py
+16
-11
No files found.
Lib/unittest/test/testmock/testpatch.py
View file @
3cf74384
...
...
@@ -9,6 +9,7 @@ import unittest
from
unittest.test.testmock
import
support
from
unittest.test.testmock.support
import
SomeClass
,
is_instance
from
test.test_importlib.util
import
uncache
from
unittest.mock
import
(
NonCallableMock
,
CallableMixin
,
sentinel
,
MagicMock
,
Mock
,
NonCallableMagicMock
,
patch
,
_patch
,
...
...
@@ -1660,20 +1661,19 @@ class PatchTest(unittest.TestCase):
def
test_patch_imports_lazily
(
self
):
sys
.
modules
.
pop
(
'squizz'
,
None
)
p1
=
patch
(
'squizz.squozz'
)
self
.
assertRaises
(
ImportError
,
p1
.
start
)
squizz
=
Mock
()
squizz
.
squozz
=
6
sys
.
modules
[
'squizz'
]
=
squizz
p1
=
patch
(
'squizz.squozz'
)
squizz
.
squozz
=
3
p1
.
start
()
p1
.
stop
()
self
.
assertEqual
(
squizz
.
squozz
,
3
)
with
uncache
(
'squizz'
):
squizz
=
Mock
()
sys
.
modules
[
'squizz'
]
=
squizz
squizz
.
squozz
=
6
p1
=
patch
(
'squizz.squozz'
)
squizz
.
squozz
=
3
p1
.
start
()
p1
.
stop
()
self
.
assertEqual
(
squizz
.
squozz
,
3
)
def
test_patch_propogrates_exc_on_exit
(
self
):
class
holder
:
...
...
@@ -1696,7 +1696,12 @@ class PatchTest(unittest.TestCase):
def
test
(
mock
):
raise
RuntimeError
self
.
assertRaises
(
RuntimeError
,
test
)
with
uncache
(
'squizz'
):
squizz
=
Mock
()
sys
.
modules
[
'squizz'
]
=
squizz
self
.
assertRaises
(
RuntimeError
,
test
)
self
.
assertIs
(
holder
.
exc_info
[
0
],
RuntimeError
)
self
.
assertIsNotNone
(
holder
.
exc_info
[
1
],
'exception value not propgated'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment