Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
3d220cc4
Commit
3d220cc4
authored
Jan 11, 2016
by
Barry Warsaw
Browse files
Options
Browse Files
Download
Plain Diff
As per further discussion, re-enable the typeobject.c guard for picklability.
upstreams such as Cython will have to adjust.
parents
ec71f177
09880c89
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
0 additions
and
12 deletions
+0
-12
Misc/NEWS
Misc/NEWS
+0
-3
Objects/typeobject.c
Objects/typeobject.c
+0
-9
No files found.
Misc/NEWS
View file @
3d220cc4
...
...
@@ -10,9 +10,6 @@ Release date: tba
Core and Builtins
-----------------
- Issue #22995: [UPDATE] Comment out the one of the pickleability tests in
_PyObject_GetState() due to regressions observed in Cython-based projects.
- Issue #25961: Disallowed null characters in the type name.
- Issue #25973: Fix segfault when an invalid nonlocal statement binds a name
...
...
Objects/typeobject.c
View file @
3d220cc4
...
...
@@ -3872,14 +3872,6 @@ _PyObject_GetState(PyObject *obj, int required)
}
assert
(
slotnames
==
Py_None
||
PyList_Check
(
slotnames
));
#if 0
/* 2016-01-11 barry - This clause breaks at least three packages which
rely on Cython: kivy, pysam, and s3ql. Cython may be doing
something funny under the hood, but as this is clearly a regression
and the rationale for this prohibition is suspect, I am commenting
this out. Perhaps it should just be removed. See issue #22995 for
details.
*/
if
(
required
)
{
Py_ssize_t
basicsize
=
PyBaseObject_Type
.
tp_basicsize
;
if
(
obj
->
ob_type
->
tp_dictoffset
)
...
...
@@ -3897,7 +3889,6 @@ _PyObject_GetState(PyObject *obj, int required)
return
NULL
;
}
}
#endif
if
(
slotnames
!=
Py_None
&&
Py_SIZE
(
slotnames
)
>
0
)
{
PyObject
*
slots
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment