Commit 3d3ffd8c authored by Ronald Oussoren's avatar Ronald Oussoren

Merged revisions 82150 via svnmerge from

svn+ssh://pythondev@svn.python.org/python/trunk

........
  r82150 | ronald.oussoren | 2010-06-22 11:32:22 +0200 (Tue, 22 Jun 2010) | 12 lines

  The code in _scproxy (a mac specific helper module to
  detect proxy settings) had the wrong logic for detecting
  if the checkbox 'Exclude simple hostnames' is checked. This
  checkin fixes that.

  As a result the test failure 'Issue8455' goes away on systems
  where the checkbox is not checked.

  I'm carefully avoiding saying that is fixes that issue,
  test_urllib2_localnet assumes that system proxy settings are
  empty (not just on OSX, see Issue8455 for details).
........
parent a5dae25b
...@@ -68,7 +68,7 @@ get_proxy_settings(PyObject* mod __attribute__((__unused__))) ...@@ -68,7 +68,7 @@ get_proxy_settings(PyObject* mod __attribute__((__unused__)))
aNum = CFDictionaryGetValue(proxyDict, aNum = CFDictionaryGetValue(proxyDict,
kSCPropNetProxiesExcludeSimpleHostnames); kSCPropNetProxiesExcludeSimpleHostnames);
if (aNum == NULL) { if (aNum == NULL) {
v = PyBool_FromLong(1); v = PyBool_FromLong(0);
} else { } else {
v = PyBool_FromLong(cfnum_to_int32(aNum)); v = PyBool_FromLong(cfnum_to_int32(aNum));
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment