Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
3f8caa3b
Commit
3f8caa3b
authored
Oct 24, 2007
by
Raymond Hettinger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Optimize sum() for integer and float inputs.
parent
cd3c108c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
72 additions
and
0 deletions
+72
-0
Misc/NEWS
Misc/NEWS
+2
-0
Python/bltinmodule.c
Python/bltinmodule.c
+70
-0
No files found.
Misc/NEWS
View file @
3f8caa3b
...
...
@@ -12,6 +12,8 @@ What's New in Python 2.6 alpha 1?
Core and builtins
-----------------
- optimize the performance of builtin.sum().
- Fix warnings found by the new version of the Coverity checker.
- The enumerate() builtin function is no longer bounded to sequences smaller
...
...
Python/bltinmodule.c
View file @
3f8caa3b
...
...
@@ -2066,6 +2066,76 @@ builtin_sum(PyObject *self, PyObject *args)
Py_INCREF
(
result
);
}
#ifndef SLOW_SUM
/* Fast addition by keeping temporary sums in C instead of new Python objects.
Assumes all inputs are the same type. If the assumption fails, default
to the more general routine.
*/
if
(
PyInt_CheckExact
(
result
))
{
long
i_result
=
PyInt_AS_LONG
(
result
);
Py_DECREF
(
result
);
result
=
NULL
;
while
(
result
==
NULL
)
{
item
=
PyIter_Next
(
iter
);
if
(
item
==
NULL
)
{
Py_DECREF
(
iter
);
if
(
PyErr_Occurred
())
return
NULL
;
return
PyInt_FromLong
(
i_result
);
}
if
(
PyInt_CheckExact
(
item
))
{
long
b
=
PyInt_AS_LONG
(
item
);
long
x
=
i_result
+
b
;
if
((
x
^
i_result
)
>=
0
||
(
x
^
b
)
>=
0
)
{
i_result
=
x
;
Py_DECREF
(
item
);
continue
;
}
}
/* Either overflowed or is not an int. Restore real objects and process normally */
result
=
PyInt_FromLong
(
i_result
);
temp
=
PyNumber_Add
(
result
,
item
);
Py_DECREF
(
result
);
Py_DECREF
(
item
);
result
=
temp
;
if
(
result
==
NULL
)
{
Py_DECREF
(
iter
);
return
NULL
;
}
}
}
if
(
PyFloat_CheckExact
(
result
))
{
double
f_result
=
PyFloat_AS_DOUBLE
(
result
);
Py_DECREF
(
result
);
result
=
NULL
;
while
(
result
==
NULL
)
{
item
=
PyIter_Next
(
iter
);
if
(
item
==
NULL
)
{
Py_DECREF
(
iter
);
if
(
PyErr_Occurred
())
return
NULL
;
return
PyFloat_FromDouble
(
f_result
);
}
if
(
PyFloat_CheckExact
(
item
))
{
PyFPE_START_PROTECT
(
"add"
,
return
0
)
f_result
+=
PyFloat_AS_DOUBLE
(
item
);
PyFPE_END_PROTECT
(
a
)
continue
;
}
result
=
PyFloat_FromDouble
(
f_result
);
temp
=
PyNumber_Add
(
result
,
item
);
Py_DECREF
(
result
);
Py_DECREF
(
item
);
result
=
temp
;
if
(
result
==
NULL
)
{
Py_DECREF
(
iter
);
return
NULL
;
}
}
}
#endif
for
(;;)
{
item
=
PyIter_Next
(
iter
);
if
(
item
==
NULL
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment