Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
3fbcc1eb
Commit
3fbcc1eb
authored
Sep 09, 2016
by
Steve Dower
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #25144: Ensures TargetDir is set before continuing with custom install.
parent
e27d291c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
0 deletions
+6
-0
Misc/NEWS
Misc/NEWS
+3
-0
Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
+3
-0
No files found.
Misc/NEWS
View file @
3fbcc1eb
...
...
@@ -275,6 +275,9 @@ Tools/Demos
Windows
-------
-
Issue
#
25144
:
Ensures
TargetDir
is
set
before
continuing
with
custom
install
.
-
Issue
#
27469
:
Adds
a
shell
extension
to
the
launcher
so
that
drag
and
drop
works
correctly
.
...
...
Tools/msi/bundle/bootstrap/PythonBootstrapperApplication.cpp
View file @
3fbcc1eb
...
...
@@ -327,6 +327,9 @@ class PythonBootstrapperApplication : public CBalBaseBootstrapperApplication {
case
ID_CUSTOM_INSTALL_BUTTON
:
SavePageSettings
();
hr
=
EnsureTargetDir
();
ExitOnFailure
(
hr
,
L"Failed to set TargetDir"
);
hr
=
BalGetStringVariable
(
L"TargetDir"
,
&
targetDir
);
if
(
SUCCEEDED
(
hr
))
{
// TODO: Check whether directory exists and contains another installation
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment