Commit 410b9887 authored by Victor Stinner's avatar Victor Stinner

Issue #27866: Fix refleak in cipher_to_dict()

parent 52d61e48
......@@ -1587,12 +1587,6 @@ cipher_to_dict(const SSL_CIPHER *cipher)
int aead, nid;
const char *skcipher = NULL, *digest = NULL, *kx = NULL, *auth = NULL;
#endif
PyObject *retval;
retval = PyDict_New();
if (retval == NULL) {
goto error;
}
/* can be NULL */
cipher_name = SSL_CIPHER_get_name(cipher);
......@@ -1616,7 +1610,7 @@ cipher_to_dict(const SSL_CIPHER *cipher)
auth = nid != NID_undef ? OBJ_nid2ln(nid) : NULL;
#endif
retval = Py_BuildValue(
return Py_BuildValue(
"{sksssssssisi"
#if OPENSSL_VERSION_1_1
"sOssssssss"
......@@ -1636,11 +1630,6 @@ cipher_to_dict(const SSL_CIPHER *cipher)
"auth", auth
#endif
);
return retval;
error:
Py_XDECREF(retval);
return NULL;
}
#endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment