bpo-30615: Fix the leak reference in Modules/_elementtree.c (#2129)

41af942e · Stéphane Wirtel · Victor Stinner · 0cc43df0 · 41af942e
Commit 41af942e authored Jun 12, 2017 by Stéphane Wirtel Committed by Victor Stinner Jun 12, 2017
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

Modules/_elementtree.c Modules/_elementtree.c +3 -1

No files found.
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -1266,8 +1266,10 @@ element_repr(ElementObject* self)
    if (status == 0) {
        PyObject *repr, *tag;
        tag = PyObject_Repr(self->tag);
-        if (!tag)
+        if (!tag) {
+            Py_ReprLeave((PyObject *)self);
            return NULL;
+        }

        repr = PyString_FromFormat("<Element %s at %p>",
                                   PyString_AS_STRING(tag), self);