Commit 445f1b35 authored by Dong-hee Na's avatar Dong-hee Na Committed by INADA Naoki

bpo-33967: Fix singledispatch raised IndexError when no args (GH-8184)

parent 7762e4d3
......@@ -817,8 +817,13 @@ def singledispatch(func):
return func
def wrapper(*args, **kw):
if not args:
raise TypeError(f'{funcname} requires at least '
'1 positional argument')
return dispatch(args[0].__class__)(*args, **kw)
funcname = getattr(func, '__name__', 'singledispatch function')
registry[object] = func
wrapper.register = register
wrapper.dispatch = dispatch
......
......@@ -2305,6 +2305,13 @@ class TestSingleDispatch(unittest.TestCase):
))
self.assertTrue(str(exc.exception).endswith(msg_suffix))
def test_invalid_positional_argument(self):
@functools.singledispatch
def f(*args):
pass
msg = 'f requires at least 1 positional argument'
with self.assertRaisesRegexp(TypeError, msg):
f()
if __name__ == '__main__':
unittest.main()
functools.singledispatch now raises TypeError instead of IndexError when no
positional arguments are passed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment