Commit 45c41494 authored by Philip Jenvey's avatar Philip Jenvey

bounds check for bad data (thanks amaury)

parent a20879ff
...@@ -645,6 +645,8 @@ class UTF8Test(ReadTest): ...@@ -645,6 +645,8 @@ class UTF8Test(ReadTest):
self.assertEqual(b"abc\xed\xa0\x80def".decode("utf-8", "surrogatepass"), self.assertEqual(b"abc\xed\xa0\x80def".decode("utf-8", "surrogatepass"),
"abc\ud800def") "abc\ud800def")
self.assertTrue(codecs.lookup_error("surrogatepass")) self.assertTrue(codecs.lookup_error("surrogatepass"))
with self.assertRaises(UnicodeDecodeError):
b"abc\xed\xa0".decode("utf-8", "surrogatepass")
class UTF7Test(ReadTest): class UTF7Test(ReadTest):
encoding = "utf-7" encoding = "utf-7"
......
...@@ -821,9 +821,10 @@ PyCodec_SurrogatePassErrors(PyObject *exc) ...@@ -821,9 +821,10 @@ PyCodec_SurrogatePassErrors(PyObject *exc)
/* Try decoding a single surrogate character. If /* Try decoding a single surrogate character. If
there are more, let the codec call us again. */ there are more, let the codec call us again. */
p += start; p += start;
if ((p[0] & 0xf0) == 0xe0 || if (strlen(p) > 2 &&
(p[1] & 0xc0) == 0x80 || ((p[0] & 0xf0) == 0xe0 ||
(p[2] & 0xc0) == 0x80) { (p[1] & 0xc0) == 0x80 ||
(p[2] & 0xc0) == 0x80)) {
/* it's a three-byte code */ /* it's a three-byte code */
ch = ((p[0] & 0x0f) << 12) + ((p[1] & 0x3f) << 6) + (p[2] & 0x3f); ch = ((p[0] & 0x0f) << 12) + ((p[1] & 0x3f) << 6) + (p[2] & 0x3f);
if (ch < 0xd800 || ch > 0xdfff) if (ch < 0xd800 || ch > 0xdfff)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment