Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
45e47e58
Commit
45e47e58
authored
Apr 09, 2011
by
Ned Deily
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue9670: Back out changeset 378b40d71175; test fails on other platforms
and on OS X with pydebug.
parent
517ac72b
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
0 additions
and
47 deletions
+0
-47
Lib/test/test_threading.py
Lib/test/test_threading.py
+0
-30
Misc/NEWS
Misc/NEWS
+0
-5
Python/thread_pthread.h
Python/thread_pthread.h
+0
-12
No files found.
Lib/test/test_threading.py
View file @
45e47e58
...
...
@@ -650,36 +650,6 @@ class ThreadingExceptionTests(unittest.TestCase):
thread
.
start
()
self
.
assertRaises
(
RuntimeError
,
setattr
,
thread
,
"daemon"
,
True
)
def
test_recursion_limit
(
self
):
# Issue 9670
# test that excessive recursion within a non-main thread causes
# an exception rather than crashing the interpreter on platforms
# like Mac OS X or FreeBSD which have small default stack sizes
# for threads
script
=
"""if True:
import threading
def recurse():
return recurse()
def outer():
try:
recurse()
except RuntimeError:
pass
w = threading.Thread(target=outer)
w.start()
w.join()
print('end of main thread')
"""
expected_output
=
"end of main thread
\
n
"
p
=
subprocess
.
Popen
([
sys
.
executable
,
"-c"
,
script
],
stdout
=
subprocess
.
PIPE
)
stdout
,
stderr
=
p
.
communicate
()
data
=
stdout
.
decode
().
replace
(
'
\
r
'
,
''
)
self
.
assertEqual
(
p
.
returncode
,
0
,
"Unexpected error"
)
self
.
assertEqual
(
data
,
expected_output
)
class
LockTests
(
lock_tests
.
LockTests
):
locktype
=
staticmethod
(
threading
.
Lock
)
...
...
Misc/NEWS
View file @
45e47e58
...
...
@@ -10,11 +10,6 @@ What's New in Python 3.1.4?
Core and Builtins
-----------------
- Issue #9670: Increase the default stack size for secondary threads on
Mac OS X and FreeBSD to reduce the chances of a crash instead of a
"maximum recursion depth" RuntimeError exception.
(original patch by Ronald Oussoren)
- Issue #11650: PyOS_StdioReadline() retries fgets() if it was interrupted
(EINTR), for example if the program is stopped with CTRL+z on Mac OS X. Patch
written by Charles-Francois Natali.
...
...
Python/thread_pthread.h
View file @
45e47e58
...
...
@@ -18,18 +18,6 @@
#ifndef THREAD_STACK_SIZE
#define THREAD_STACK_SIZE 0
/* use default stack size */
#endif
#if (defined(__APPLE__) || defined(__FreeBSD__)) && defined(THREAD_STACK_SIZE) && THREAD_STACK_SIZE == 0
/* The default stack size for new threads on OSX is small enough that
* we'll get hard crashes instead of 'maximum recursion depth exceeded'
* exceptions.
*
* The default stack size below is the minimal stack size where a
* simple recursive function doesn't cause a hard crash.
*/
#undef THREAD_STACK_SIZE
#define THREAD_STACK_SIZE 0x100000
#endif
/* for safety, ensure a viable minimum stacksize */
#define THREAD_STACK_MIN 0x8000
/* 32kB */
#else
/* !_POSIX_THREAD_ATTR_STACKSIZE */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment