Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
46c0c60d
Commit
46c0c60d
authored
Dec 05, 2007
by
Raymond Hettinger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Error checking was too aggressive (reported by Chris Tismer)
parent
19f3d22e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
Lib/collections.py
Lib/collections.py
+2
-2
Lib/test/test_collections.py
Lib/test/test_collections.py
+1
-0
No files found.
Lib/collections.py
View file @
46c0c60d
...
...
@@ -40,7 +40,7 @@ def namedtuple(typename, field_names, verbose=False):
field_names
=
field_names
.
replace
(
','
,
' '
).
split
()
# names separated by whitespace and/or commas
field_names
=
tuple
(
field_names
)
for
name
in
(
typename
,)
+
field_names
:
if
not
name
.
replace
(
'_'
,
''
).
isalnum
(
):
if
not
all
(
c
.
isalnum
()
or
c
==
'_'
for
c
in
name
):
raise
ValueError
(
'Type names and field names can only contain alphanumeric characters and underscores: %r'
%
name
)
if
_iskeyword
(
name
):
raise
ValueError
(
'Type names and field names cannot be a keyword: %r'
%
name
)
...
...
@@ -48,7 +48,7 @@ def namedtuple(typename, field_names, verbose=False):
raise
ValueError
(
'Type names and field names cannot start with a number: %r'
%
name
)
seen_names
=
set
()
for
name
in
field_names
:
if
name
.
startswith
(
'__'
)
and
name
.
endswith
(
'__'
):
if
name
.
startswith
(
'__'
)
and
name
.
endswith
(
'__'
)
and
len
(
name
)
>
3
:
raise
ValueError
(
'Field names cannot start and end with double underscores: %r'
%
name
)
if
name
in
seen_names
:
raise
ValueError
(
'Encountered duplicate field name: %r'
%
name
)
...
...
Lib/test/test_collections.py
View file @
46c0c60d
...
...
@@ -29,6 +29,7 @@ class TestNamedTuple(unittest.TestCase):
self
.
assertRaises
(
ValueError
,
namedtuple
,
'abc'
,
'efg efg ghi'
)
# duplicate field
namedtuple
(
'Point0'
,
'x1 y2'
)
# Verify that numbers are allowed in names
namedtuple
(
'_'
,
'_ __ ___'
)
# Verify that underscores are allowed
def
test_instance
(
self
):
Point
=
namedtuple
(
'Point'
,
'x y'
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment