Commit 480968f5 authored by Raymond Hettinger's avatar Raymond Hettinger

Add error-checking to namedtuple's _replace() method.

parent 80cabad1
......@@ -410,7 +410,10 @@ Example::
def _replace(self, **kwds):
'Return a new Point object replacing specified fields with new values'
return self.__class__._make(map(kwds.get, ('x', 'y'), self))
result = self.__class__._make(map(kwds.pop, ('x', 'y'), self))
if kwds:
raise ValueError('Got unexpected field names: %r' % kwds.keys())
return result
x = property(itemgetter(0))
y = property(itemgetter(1))
......
......@@ -78,7 +78,10 @@ def namedtuple(typename, field_names, verbose=False):
return {%(dicttxt)s} \n
def _replace(self, **kwds):
'Return a new %(typename)s object replacing specified fields with new values'
return self.__class__._make(map(kwds.get, %(field_names)r, self)) \n\n''' % locals()
result = self.__class__._make(map(kwds.pop, %(field_names)r, self))
if kwds:
raise ValueError('Got unexpected field names: %%r' %% kwds.keys())
return result \n\n''' % locals()
for i, name in enumerate(field_names):
template += ' %s = property(itemgetter(%d))\n' % (name, i)
if verbose:
......
......@@ -55,6 +55,13 @@ class TestNamedTuple(unittest.TestCase):
self.assertEqual(p._replace(x=1), (1, 22)) # test _replace method
self.assertEqual(p._asdict(), dict(x=11, y=22)) # test _asdict method
try:
p._replace(x=1, error=2)
except ValueError:
pass
else:
self._fail('Did not detect an incorrect fieldname')
# verify that field string can have commas
Point = namedtuple('Point', 'x, y')
p = Point(x=11, y=22)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment