Commit 48305667 authored by Vinay Sajip's avatar Vinay Sajip

logging: Added optional 'secure' parameter to SMTPHandler.

parent 42d63847
...@@ -809,7 +809,8 @@ class SMTPHandler(logging.Handler): ...@@ -809,7 +809,8 @@ class SMTPHandler(logging.Handler):
""" """
A handler class which sends an SMTP email for each logging event. A handler class which sends an SMTP email for each logging event.
""" """
def __init__(self, mailhost, fromaddr, toaddrs, subject, credentials=None): def __init__(self, mailhost, fromaddr, toaddrs, subject,
credentials=None, secure=False):
""" """
Initialize the handler. Initialize the handler.
...@@ -817,7 +818,9 @@ class SMTPHandler(logging.Handler): ...@@ -817,7 +818,9 @@ class SMTPHandler(logging.Handler):
line of the email. To specify a non-standard SMTP port, use the line of the email. To specify a non-standard SMTP port, use the
(host, port) tuple format for the mailhost argument. To specify (host, port) tuple format for the mailhost argument. To specify
authentication credentials, supply a (username, password) tuple authentication credentials, supply a (username, password) tuple
for the credentials argument. for the credentials argument. To specify the use of a secure
protocol (TLS), pass in True for the secure argument. This will
only be used when authentication credentials are supplied.
""" """
logging.Handler.__init__(self) logging.Handler.__init__(self)
if isinstance(mailhost, tuple): if isinstance(mailhost, tuple):
...@@ -833,6 +836,7 @@ class SMTPHandler(logging.Handler): ...@@ -833,6 +836,7 @@ class SMTPHandler(logging.Handler):
toaddrs = [toaddrs] toaddrs = [toaddrs]
self.toaddrs = toaddrs self.toaddrs = toaddrs
self.subject = subject self.subject = subject
self.secure = secure
def getSubject(self, record): def getSubject(self, record):
""" """
...@@ -884,6 +888,10 @@ class SMTPHandler(logging.Handler): ...@@ -884,6 +888,10 @@ class SMTPHandler(logging.Handler):
self.getSubject(record), self.getSubject(record),
formatdate(), msg) formatdate(), msg)
if self.username: if self.username:
if self.secure:
smtp.ehlo()
smtp.starttls()
smtp.ehlo()
smtp.login(self.username, self.password) smtp.login(self.username, self.password)
smtp.sendmail(self.fromaddr, self.toaddrs, msg) smtp.sendmail(self.fromaddr, self.toaddrs, msg)
smtp.quit() smtp.quit()
......
...@@ -507,6 +507,9 @@ Core and Builtins ...@@ -507,6 +507,9 @@ Core and Builtins
Library Library
------- -------
- logging: Added optional `secure` parameter to SMTPHandler, to enable use of
TLS with authentication credentials.
- Issue #1923: Fixed the removal of meaningful spaces when PKG-INFO is - Issue #1923: Fixed the removal of meaningful spaces when PKG-INFO is
generated in Distutils. Patch by Stephen Emslie. generated in Distutils. Patch by Stephen Emslie.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment