Skip to content
GitLab
Projects
Groups
Snippets
Help
Loading...
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Open sidebar
Kirill Smelkov
cpython
Commits
484f8a87
Commit
484f8a87
authored
11 years ago
by
Kushal Das
Browse files
Options
Download
Email Patches
Plain Diff
Closes Issue 21222.
Passing name keyword argument to mock.create_autospec now works.
parent
9574355f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
9 additions
and
0 deletions
+9
-0
Lib/unittest/mock.py
Lib/unittest/mock.py
+2
-0
Lib/unittest/test/testmock/testmock.py
Lib/unittest/test/testmock/testmock.py
+4
-0
Misc/NEWS
Misc/NEWS
+3
-0
No files found.
Lib/unittest/mock.py
View file @
484f8a87
...
...
@@ -2096,6 +2096,8 @@ def create_autospec(spec, spec_set=False, instance=False, _parent=None,
elif
is_type
and
instance
and
not
_instance_callable
(
spec
):
Klass
=
NonCallableMagicMock
_name
=
_kwargs
.
pop
(
'name'
,
_name
)
_new_name
=
_name
if
_parent
is
None
:
# for a top level object no _new_name should be set
...
...
This diff is collapsed.
Click to expand it.
Lib/unittest/test/testmock/testmock.py
View file @
484f8a87
...
...
@@ -1182,6 +1182,10 @@ class MockTest(unittest.TestCase):
func
.
mock_calls
,
[
call
(
1
,
2
),
call
(
3
,
4
)]
)
#Issue21222
def
test_create_autospec_with_name
(
self
):
m
=
mock
.
create_autospec
(
object
(),
name
=
'sweet_func'
)
self
.
assertIn
(
'sweet_func'
,
repr
(
m
))
def
test_mock_add_spec
(
self
):
class
_One
(
object
):
...
...
This diff is collapsed.
Click to expand it.
Misc/NEWS
View file @
484f8a87
...
...
@@ -37,6 +37,9 @@ Core and Builtins
Library
-------
- Issue #21222: Passing name keyword argument to mock.create_autospec now
works.
- Issue #21197: Add lib64 -> lib symlink in venvs on 64-bit non-OS X POSIX.
- Issue #17498: Some SMTP servers disconnect after certain errors, violating
...
...
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment