Commit 4ac7ed97 authored by Serhiy Storchaka's avatar Serhiy Storchaka

Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port

value in the host header was set to "None".  Patch by Demian Brecht.
parent 1e40f108
...@@ -771,8 +771,7 @@ class HTTPConnection: ...@@ -771,8 +771,7 @@ class HTTPConnection:
if self.sock: if self.sock:
raise RuntimeError("Can't set up tunnel for established connection") raise RuntimeError("Can't set up tunnel for established connection")
self._tunnel_host = host self._tunnel_host, self._tunnel_port = self._get_hostport(host, port)
self._tunnel_port = port
if headers: if headers:
self._tunnel_headers = headers self._tunnel_headers = headers
else: else:
...@@ -802,9 +801,8 @@ class HTTPConnection: ...@@ -802,9 +801,8 @@ class HTTPConnection:
self.debuglevel = level self.debuglevel = level
def _tunnel(self): def _tunnel(self):
(host, port) = self._get_hostport(self._tunnel_host, connect_str = "CONNECT %s:%d HTTP/1.0\r\n" % (self._tunnel_host,
self._tunnel_port) self._tunnel_port)
connect_str = "CONNECT %s:%d HTTP/1.0\r\n" % (host, port)
connect_bytes = connect_str.encode("ascii") connect_bytes = connect_str.encode("ascii")
self.send(connect_bytes) self.send(connect_bytes)
for header, value in self._tunnel_headers.items(): for header, value in self._tunnel_headers.items():
......
...@@ -1068,11 +1068,13 @@ class TunnelTests(TestCase): ...@@ -1068,11 +1068,13 @@ class TunnelTests(TestCase):
self.assertEqual(conn.sock.host, 'proxy.com') self.assertEqual(conn.sock.host, 'proxy.com')
self.assertEqual(conn.sock.port, 80) self.assertEqual(conn.sock.port, 80)
self.assertTrue(b'CONNECT destination.com' in conn.sock.data) self.assertIn(b'CONNECT destination.com', conn.sock.data)
self.assertTrue(b'Host: destination.com' in conn.sock.data) # issue22095
self.assertNotIn(b'Host: destination.com:None', conn.sock.data)
self.assertIn(b'Host: destination.com', conn.sock.data)
# This test should be removed when CONNECT gets the HTTP/1.1 blessing # This test should be removed when CONNECT gets the HTTP/1.1 blessing
self.assertTrue(b'Host: proxy.com' not in conn.sock.data) self.assertNotIn(b'Host: proxy.com', conn.sock.data)
conn.close() conn.close()
conn.request('PUT', '/', '') conn.request('PUT', '/', '')
......
...@@ -39,6 +39,9 @@ Core and Builtins ...@@ -39,6 +39,9 @@ Core and Builtins
Library Library
------- -------
- Issue #22095: Fixed HTTPConnection.set_tunnel with default port. The port
value in the host header was set to "None". Patch by Demian Brecht.
- Issue #23016: A warning no longer produces an AttributeError when the program - Issue #23016: A warning no longer produces an AttributeError when the program
is run with pythonw.exe. is run with pythonw.exe.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment