Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
4b03398f
Commit
4b03398f
authored
Mar 20, 2015
by
Serhiy Storchaka
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Issue #23681: The -b option now affects comparisons of bytes with int.
parent
e4d25ee6
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
53 additions
and
22 deletions
+53
-22
Doc/using/cmdline.rst
Doc/using/cmdline.rst
+4
-1
Doc/whatsnew/3.5.rst
Doc/whatsnew/3.5.rst
+2
-0
Lib/test/test_bytes.py
Lib/test/test_bytes.py
+28
-13
Misc/NEWS
Misc/NEWS
+2
-0
Objects/bytesobject.c
Objects/bytesobject.c
+17
-8
No files found.
Doc/using/cmdline.rst
View file @
4b03398f
...
...
@@ -190,9 +190,12 @@ Miscellaneous options
..
cmdoption
::
-
b
Issue
a
warning
when
comparing
str
and
bytes
.
Issue
an
error
when
the
Issue
a
warning
when
comparing
:
class
:`
bytes
`
or
:
class
:`
bytearray
`
with
:
class
:`
str
`
or
:
class
:`
bytes
`
with
:
class
:`
int
`.
Issue
an
error
when
the
option
is
given
twice
(:
option
:`-
bb
`).
..
versionchanged
:
3.5
Affects
comparisons
of
:
class
:`
bytes
`
with
:
class
:`
int
`.
..
cmdoption
::
-
B
...
...
Doc/whatsnew/3.5.rst
View file @
4b03398f
...
...
@@ -162,6 +162,8 @@ Some smaller changes made to the core Python language are:
error handlers now works with decoding and translating.
(Contributed by Serhiy Storchaka in :issue:`19676` and :issue:`22286`.)
* The :option:`-b` option now affects comparisons of :class:`bytes` with
:class:`int`. (Contributed by Serhiy Storchaka in :issue:`23681`)
New Modules
...
...
Lib/test/test_bytes.py
View file @
4b03398f
...
...
@@ -1338,20 +1338,35 @@ class AssortedBytesTest(unittest.TestCase):
b = bytearray()
self.assertFalse(b.replace(b'', b'') is b)
@unittest.skipUnless(sys.flags.bytes_warning,
"BytesWarning is needed for this test: use -bb option")
def test_compare(self):
if sys.flags.bytes_warning:
def bytes_warning():
return test.support.check_warnings(('', BytesWarning))
with bytes_warning():
b'' == ''
with bytes_warning():
b'' != ''
with bytes_warning():
bytearray(b'') == ''
with bytes_warning():
bytearray(b'') != ''
else:
self.skipTest("BytesWarning is needed for this test: use -bb option")
def bytes_warning():
return test.support.check_warnings(('', BytesWarning))
with bytes_warning():
b'' == ''
with bytes_warning():
'' == b''
with bytes_warning():
b'' != ''
with bytes_warning():
'' != b''
with bytes_warning():
bytearray(b'') == ''
with bytes_warning():
'' == bytearray(b'')
with bytes_warning():
bytearray(b'') != ''
with bytes_warning():
'' != bytearray(b'')
with bytes_warning():
b'
\
0
' == 0
with bytes_warning():
0 == b'
\
0
'
with bytes_warning():
b'
\
0
' != 0
with bytes_warning():
0 != b'
\
0
'
# Optimizations:
# __iter__? (optimization)
...
...
Misc/NEWS
View file @
4b03398f
...
...
@@ -10,6 +10,8 @@ Release date: 2015-03-28
Core and Builtins
-----------------
- Issue #23681: The -b option now affects comparisons of bytes with int.
- Issue #23632: Memoryviews now allow tuple indexing (including for
multi-dimensional memoryviews).
...
...
Objects/bytesobject.c
View file @
4b03398f
...
...
@@ -1385,14 +1385,23 @@ bytes_richcompare(PyBytesObject *a, PyBytesObject *b, int op)
/* Make sure both arguments are strings. */
if
(
!
(
PyBytes_Check
(
a
)
&&
PyBytes_Check
(
b
)))
{
if
(
Py_BytesWarningFlag
&&
(
op
==
Py_EQ
||
op
==
Py_NE
)
&&
(
PyObject_IsInstance
((
PyObject
*
)
a
,
(
PyObject
*
)
&
PyUnicode_Type
)
||
PyObject_IsInstance
((
PyObject
*
)
b
,
(
PyObject
*
)
&
PyUnicode_Type
)))
{
if
(
PyErr_WarnEx
(
PyExc_BytesWarning
,
"Comparison between bytes and string"
,
1
))
return
NULL
;
if
(
Py_BytesWarningFlag
&&
(
op
==
Py_EQ
||
op
==
Py_NE
))
{
if
(
PyObject_IsInstance
((
PyObject
*
)
a
,
(
PyObject
*
)
&
PyUnicode_Type
)
||
PyObject_IsInstance
((
PyObject
*
)
b
,
(
PyObject
*
)
&
PyUnicode_Type
))
{
if
(
PyErr_WarnEx
(
PyExc_BytesWarning
,
"Comparison between bytes and string"
,
1
))
return
NULL
;
}
else
if
(
PyObject_IsInstance
((
PyObject
*
)
a
,
(
PyObject
*
)
&
PyLong_Type
)
||
PyObject_IsInstance
((
PyObject
*
)
b
,
(
PyObject
*
)
&
PyLong_Type
))
{
if
(
PyErr_WarnEx
(
PyExc_BytesWarning
,
"Comparison between bytes and int"
,
1
))
return
NULL
;
}
}
result
=
Py_NotImplemented
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment