Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
4c7c9af5
Commit
4c7c9af5
authored
Sep 05, 2010
by
Raymond Hettinger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean-up functools.total_ordering().
parent
bb734c67
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
5 deletions
+3
-5
Lib/functools.py
Lib/functools.py
+2
-4
Misc/NEWS
Misc/NEWS
+1
-1
No files found.
Lib/functools.py
View file @
4c7c9af5
...
...
@@ -65,7 +65,6 @@ def wraps(wrapped,
return
partial
(
update_wrapper
,
wrapped
=
wrapped
,
assigned
=
assigned
,
updated
=
updated
)
_object_defaults
=
{
object
.
__lt__
,
object
.
__le__
,
object
.
__gt__
,
object
.
__ge__
}
def
total_ordering
(
cls
):
"""Class decorator that fills in missing ordering methods"""
convert
=
{
...
...
@@ -82,9 +81,8 @@ def total_ordering(cls):
(
'__gt__'
,
lambda
self
,
other
:
not
other
>=
self
),
(
'__lt__'
,
lambda
self
,
other
:
not
self
>=
other
)]
}
roots
=
set
(
dir
(
cls
))
&
set
(
convert
)
# Remove default comparison operations defined on object.
roots
-=
{
meth
for
meth
in
roots
if
getattr
(
cls
,
meth
)
in
_object_defaults
}
# Find comparisons not inherited from object.
roots
=
[
op
for
op
in
convert
if
getattr
(
cls
,
op
)
is
not
getattr
(
object
,
op
)]
if
not
roots
:
raise
ValueError
(
'must define at least one ordering operation: < > <= >='
)
root
=
max
(
roots
)
# prefer __lt__ to __le__ to __gt__ to __ge__
...
...
Misc/NEWS
View file @
4c7c9af5
...
...
@@ -222,7 +222,7 @@ Library
- Issue #9501: Fixed logging regressions in cleanup code.
- Fix functools.total_ordering() to
actually work
.
- Fix functools.total_ordering() to
skip methods inherited from object()
.
- Issue #9572: Importlib should not raise an exception if a directory it
thought it needed to create was done concurrently by another process.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment