Fix a possible "double decref" in termios.tcgetattr(). (GH-10194)

53835e92 · Zackery Spytz · Serhiy Storchaka · ea9c8bd4 · 53835e92
Commit 53835e92 authored Oct 28, 2018 by Zackery Spytz Committed by Serhiy Storchaka Oct 29, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

Modules/termios.c Modules/termios.c +2 -2

No files found.
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -119,11 +119,11 @@ termios_tcgetattr(PyObject *self, PyObject *args)
    PyList_SetItem(v, 3, PyLong_FromLong((long)mode.c_lflag));
    PyList_SetItem(v, 4, PyLong_FromLong((long)ispeed));
    PyList_SetItem(v, 5, PyLong_FromLong((long)ospeed));
-    PyList_SetItem(v, 6, cc);
+    if (PyErr_Occurred()) {
-    if (PyErr_Occurred()){
        Py_DECREF(v);
        goto err;
    }
+    PyList_SetItem(v, 6, cc);
    return v;
  err:
    Py_DECREF(cc);