Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
568867a6
Commit
568867a6
authored
Sep 11, 2010
by
Benjamin Peterson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
check for NULL tp_as_mapping in PySequence_(Get/Set/Del)Slice #9834
parent
e861598d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
10 additions
and
3 deletions
+10
-3
Misc/NEWS
Misc/NEWS
+7
-0
Objects/abstract.c
Objects/abstract.c
+3
-3
No files found.
Misc/NEWS
View file @
568867a6
...
...
@@ -108,6 +108,13 @@ Library
guaranteed to exist in all Python implementations and the names of hash
algorithms available in the current process.
C-API
-----
- Issue #9834: Don't segfault in PySequence_GetSlice, PySequence_SetSlice, or
PySequence_DelSlice when the object doesn't have any mapping operations
defined.
Tools/Demos
-----------
...
...
Objects/abstract.c
View file @
568867a6
...
...
@@ -1612,7 +1612,7 @@ PySequence_GetSlice(PyObject *s, Py_ssize_t i1, Py_ssize_t i2)
if
(
!
s
)
return
null_error
();
mp
=
s
->
ob_type
->
tp_as_mapping
;
if
(
mp
->
mp_subscript
)
{
if
(
mp
&&
mp
->
mp_subscript
)
{
PyObject
*
res
;
PyObject
*
slice
=
_PySlice_FromIndices
(
i1
,
i2
);
if
(
!
slice
)
...
...
@@ -1690,7 +1690,7 @@ PySequence_SetSlice(PyObject *s, Py_ssize_t i1, Py_ssize_t i2, PyObject *o)
}
mp
=
s
->
ob_type
->
tp_as_mapping
;
if
(
mp
->
mp_ass_subscript
)
{
if
(
mp
&&
mp
->
mp_ass_subscript
)
{
int
res
;
PyObject
*
slice
=
_PySlice_FromIndices
(
i1
,
i2
);
if
(
!
slice
)
...
...
@@ -1715,7 +1715,7 @@ PySequence_DelSlice(PyObject *s, Py_ssize_t i1, Py_ssize_t i2)
}
mp
=
s
->
ob_type
->
tp_as_mapping
;
if
(
mp
->
mp_ass_subscript
)
{
if
(
mp
&&
mp
->
mp_ass_subscript
)
{
int
res
;
PyObject
*
slice
=
_PySlice_FromIndices
(
i1
,
i2
);
if
(
!
slice
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment