os.dup()-then-close() can be replaced with detach()

5aa878c6 · Antoine Pitrou · 2341f9ba · 5aa878c6
Commit 5aa878c6 authored May 09, 2011 by Antoine Pitrou
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

Lib/multiprocessing/connection.py Lib/multiprocessing/connection.py +2 -4

No files found.
--- a/Lib/multiprocessing/connection.py
+++ b/Lib/multiprocessing/connection.py
@@ -469,10 +469,8 @@ if sys.platform != 'win32':
        '''
        if duplex:
            s1, s2 = socket.socketpair()
-            c1 = Connection(os.dup(s1.fileno()))
+            c1 = Connection(s1.detach())
-            c2 = Connection(os.dup(s2.fileno()))
+            c2 = Connection(s2.detach())
-            s1.close()
-            s2.close()
        else:
            fd1, fd2 = os.pipe()
            c1 = Connection(fd1, writable=False)