Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
5c2ac8c1
Commit
5c2ac8c1
authored
Apr 30, 2014
by
Benjamin Peterson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
setup.py: report modules which built but import failed (closes #21282)
Patch by Lukas Vacek.
parent
30a6df5b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
3 deletions
+14
-3
Misc/ACKS
Misc/ACKS
+1
-0
setup.py
setup.py
+13
-3
No files found.
Misc/ACKS
View file @
5c2ac8c1
...
...
@@ -1356,6 +1356,7 @@ Roger Upole
Daniel Urban
Michael Urman
Hector Urtubia
Lukas Vacek
Ville Vainio
Andi Vajda
Case Van Horsen
...
...
setup.py
View file @
5c2ac8c1
...
...
@@ -167,6 +167,7 @@ class PyBuildExt(build_ext):
def
__init__
(
self
,
dist
):
build_ext
.
__init__
(
self
,
dist
)
self
.
failed
=
[]
self
.
failed_on_import
=
[]
def
build_extensions
(
self
):
...
...
@@ -247,8 +248,9 @@ class PyBuildExt(build_ext):
build_ext
.
build_extensions
(
self
)
longest
=
max
([
len
(
e
.
name
)
for
e
in
self
.
extensions
])
if
self
.
failed
:
longest
=
max
(
longest
,
max
([
len
(
name
)
for
name
in
self
.
failed
]))
if
self
.
failed
or
self
.
failed_on_import
:
all_failed
=
self
.
failed
+
self
.
failed_on_import
longest
=
max
(
longest
,
max
([
len
(
name
)
for
name
in
all_failed
]))
def
print_three_column
(
lst
):
lst
.
sort
(
key
=
str
.
lower
)
...
...
@@ -276,6 +278,14 @@ class PyBuildExt(build_ext):
print_three_column
(
failed
)
print
()
if
self
.
failed_on_import
:
failed
=
self
.
failed_on_import
[:]
print
()
print
(
"Following modules built successfully"
" but were removed because they could not be imported:"
)
print_three_column
(
failed
)
print
()
def
build_extension
(
self
,
ext
):
if
ext
.
name
==
'_ctypes'
:
...
...
@@ -334,7 +344,7 @@ class PyBuildExt(build_ext):
try
:
importlib
.
_bootstrap
.
_SpecMethods
(
spec
).
load
()
except
ImportError
as
why
:
self
.
failed
.
append
(
ext
.
name
)
self
.
failed
_on_import
.
append
(
ext
.
name
)
self
.
announce
(
'*** WARNING: renaming "%s" since importing it'
' failed: %s'
%
(
ext
.
name
,
why
),
level
=
3
)
assert
not
self
.
inplace
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment