Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
5e19e444
Commit
5e19e444
authored
Sep 10, 2008
by
Benjamin Peterson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
kill memoryview.size in favor of len(view)
Reviewer: Antoine Pitrou #3827
parent
2409dc79
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
12 deletions
+5
-12
Doc/library/stdtypes.rst
Doc/library/stdtypes.rst
+2
-4
Lib/test/test_memoryview.py
Lib/test/test_memoryview.py
+1
-1
Misc/NEWS
Misc/NEWS
+2
-0
Objects/memoryobject.c
Objects/memoryobject.c
+0
-7
No files found.
Doc/library/stdtypes.rst
View file @
5e19e444
...
...
@@ -2246,6 +2246,8 @@ simple bytes or complex data structures.
buffer protocol. Builtin objects that support the buffer protocol include
:class:`bytes` and :class:`bytearray`.
``len(view)`` returns the total number of bytes in the memoryview, *view*.
A :class:`memoryview` supports slicing to expose its data. Taking a single
index will return a single byte. Full slicing will result in a subview::
...
...
@@ -2322,10 +2324,6 @@ simple bytes or complex data structures.
A tuple of integers the length of :attr:`ndim` giving the size in bytes to
access each element for each dimension of the array.
.. attribute:: size
The number of bytes in the buffer. Also available as ``len(view)``.
.. memoryview.suboffsets isn't documented because it only seems useful for C
...
...
Lib/test/test_memoryview.py
View file @
5e19e444
...
...
@@ -146,7 +146,7 @@ class CommonMemoryTests:
self
.
assertEquals
(
m
.
itemsize
,
1
)
self
.
assertEquals
(
m
.
ndim
,
1
)
self
.
assertEquals
(
m
.
shape
,
(
6
,))
self
.
assertEquals
(
m
.
size
,
6
)
self
.
assertEquals
(
len
(
m
)
,
6
)
self
.
assertEquals
(
m
.
strides
,
(
1
,))
self
.
assertEquals
(
m
.
suboffsets
,
None
)
return
m
...
...
Misc/NEWS
View file @
5e19e444
...
...
@@ -12,6 +12,8 @@ What's New in Python 3.0 release candidate 1
Core and Builtins
-----------------
- Issue #3827: memoryview lost its size attribute in favor of using len(view).
- Issue #3813: could not lanch python.exe via symbolic link on cygwin.
- Issue #3705: fix crash when given a non-ascii value on the command line for
...
...
Objects/memoryobject.c
View file @
5e19e444
...
...
@@ -369,12 +369,6 @@ memory_suboffsets_get(PyMemoryViewObject *self)
return
_IntTupleFromSsizet
(
self
->
view
.
ndim
,
self
->
view
.
suboffsets
);
}
static
PyObject
*
memory_size_get
(
PyMemoryViewObject
*
self
)
{
return
PyLong_FromSsize_t
(
self
->
view
.
len
);
}
static
PyObject
*
memory_readonly_get
(
PyMemoryViewObject
*
self
)
{
...
...
@@ -393,7 +387,6 @@ static PyGetSetDef memory_getsetlist[] ={
{
"shape"
,
(
getter
)
memory_shape_get
,
NULL
,
NULL
},
{
"strides"
,
(
getter
)
memory_strides_get
,
NULL
,
NULL
},
{
"suboffsets"
,
(
getter
)
memory_suboffsets_get
,
NULL
,
NULL
},
{
"size"
,
(
getter
)
memory_size_get
,
NULL
,
NULL
},
{
"readonly"
,
(
getter
)
memory_readonly_get
,
NULL
,
NULL
},
{
"ndim"
,
(
getter
)
memory_ndim_get
,
NULL
,
NULL
},
{
NULL
,
NULL
,
NULL
,
NULL
},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment