Commit 620c6c76 authored by Brett Cannon's avatar Brett Cannon

Having CFLAGS come before OPT prevents silencing certain classes of warnings

from the fact that OPT contains -Wall be default. This is annoying when
compilers like clang have thorough debugging information about things that
Python does extensively (e.g. -Wunused-value for unused return values caused by
a macro use).
parent 1341f57c
...@@ -59,7 +59,7 @@ MAKESETUP= $(srcdir)/Modules/makesetup ...@@ -59,7 +59,7 @@ MAKESETUP= $(srcdir)/Modules/makesetup
# Compiler options # Compiler options
OPT= @OPT@ OPT= @OPT@
BASECFLAGS= @BASECFLAGS@ BASECFLAGS= @BASECFLAGS@
CFLAGS= $(BASECFLAGS) @CFLAGS@ $(OPT) $(EXTRA_CFLAGS) CFLAGS= $(BASECFLAGS) $(OPT) @CFLAGS@ $(EXTRA_CFLAGS)
# Both CPPFLAGS and LDFLAGS need to contain the shell's value for setup.py to # Both CPPFLAGS and LDFLAGS need to contain the shell's value for setup.py to
# be able to build extension modules using the directories specified in the # be able to build extension modules using the directories specified in the
# environment variables # environment variables
......
...@@ -1461,6 +1461,8 @@ Extension Modules ...@@ -1461,6 +1461,8 @@ Extension Modules
Build Build
----- -----
- Have CFLAGS come after OPT to allow for overriding warnings flags.
- Issue #8854: Fix finding Visual Studio 2008 on Windows x64. - Issue #8854: Fix finding Visual Studio 2008 on Windows x64.
- Issue #1759169, #8864: Drop _XOPEN_SOURCE on Solaris, define it for - Issue #1759169, #8864: Drop _XOPEN_SOURCE on Solaris, define it for
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment