[2.7] Fix a possible "double decref" in termios.tcgetattr(). (GH-10194) (GH-10218)

(cherry picked from commit 53835e92)

[2.7] Fix a possible "double decref" in termios.tcgetattr(). (GH-10194) (GH-10218)
(cherry picked from commit 53835e92)
64ffee7a · Zackery Spytz · Serhiy Storchaka · 4ec427b0 · 64ffee7a
Commit 64ffee7a authored Oct 29, 2018 by Zackery Spytz Committed by Serhiy Storchaka Oct 29, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

Modules/termios.c Modules/termios.c +2 -2

No files found.
--- a/Modules/termios.c
+++ b/Modules/termios.c
@@ -120,11 +120,11 @@ termios_tcgetattr(PyObject *self, PyObject *args)
    PyList_SetItem(v, 3, PyInt_FromLong((long)mode.c_lflag));
    PyList_SetItem(v, 4, PyInt_FromLong((long)ispeed));
    PyList_SetItem(v, 5, PyInt_FromLong((long)ospeed));
-    PyList_SetItem(v, 6, cc);
+    if (PyErr_Occurred()) {
-    if (PyErr_Occurred()){
        Py_DECREF(v);
        goto err;
    }
+    PyList_SetItem(v, 6, cc);
    return v;
  err:
    Py_DECREF(cc);