Commit 67dfb6f0 authored by Neal Norwitz's avatar Neal Norwitz

I think the test_logging failure on Solaris is timing related. We don't

want to wait forever if we don't receive the last message.  But we also
don't want the test to fail if we shutdown too quickly.  I can't reliably
reproduce this failure, so I'm kinda guessing this is the problem.
We'll see if this band-aid helps.
parent 10be2ea8
......@@ -98,13 +98,22 @@ class LogRecordSocketReceiver(ThreadingTCPServer):
self.abort = 0
self.timeout = 1
def _wait_and_process_data(self):
rd, wr, ex = select.select([self.socket.fileno()], [], [],
self.timeout)
if rd:
self.handle_request()
def serve_until_stopped(self):
while not self.abort:
rd, wr, ex = select.select([self.socket.fileno()],
[], [],
self.timeout)
if rd:
self.handle_request()
self._wait_and_process_data()
# XXX(nnorwitz): Try to fix timing related test failures.
# It's possible self.aborted was set before the final message
# was received. By calling _wait_and_process_data(),
# it gives us one last chance to read messages.
# The test generally only fails on Solaris.
self._wait_and_process_data()
#notify the main thread that we're about to exit
socketDataProcessed.set()
# close the listen socket
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment