Commit 6d7e2965 authored by Vinay Sajip's avatar Vinay Sajip

Issue #18940: Handled low-volume logging when delay is True.

parent 6971f2e6
...@@ -137,7 +137,9 @@ class RotatingFileHandler(BaseRotatingHandler): ...@@ -137,7 +137,9 @@ class RotatingFileHandler(BaseRotatingHandler):
dfn = self.baseFilename + ".1" dfn = self.baseFilename + ".1"
if os.path.exists(dfn): if os.path.exists(dfn):
os.remove(dfn) os.remove(dfn)
os.rename(self.baseFilename, dfn) # Issue 18940: A file may not have been created if delay is True.
if os.path.exists(self.baseFilename):
os.rename(self.baseFilename, dfn)
#print "%s -> %s" % (self.baseFilename, dfn) #print "%s -> %s" % (self.baseFilename, dfn)
self.stream = self._open() self.stream = self._open()
...@@ -343,7 +345,9 @@ class TimedRotatingFileHandler(BaseRotatingHandler): ...@@ -343,7 +345,9 @@ class TimedRotatingFileHandler(BaseRotatingHandler):
dfn = self.baseFilename + "." + time.strftime(self.suffix, timeTuple) dfn = self.baseFilename + "." + time.strftime(self.suffix, timeTuple)
if os.path.exists(dfn): if os.path.exists(dfn):
os.remove(dfn) os.remove(dfn)
os.rename(self.baseFilename, dfn) # Issue 18940: A file may not have been created if delay is True.
if os.path.exists(self.baseFilename):
os.rename(self.baseFilename, dfn)
if self.backupCount > 0: if self.backupCount > 0:
# find the oldest log file and delete it # find the oldest log file and delete it
#s = glob.glob(self.baseFilename + ".20*") #s = glob.glob(self.baseFilename + ".20*")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment