Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
6e27a0d7
Commit
6e27a0d7
authored
Sep 15, 2019
by
Raymond Hettinger
Committed by
GitHub
Sep 15, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-37798: Prevent undefined behavior in direct calls to the C helper function. (#16149)
parent
09dc2c67
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
17 additions
and
1 deletion
+17
-1
Modules/_statisticsmodule.c
Modules/_statisticsmodule.c
+17
-1
No files found.
Modules/_statisticsmodule.c
View file @
6e27a0d7
...
...
@@ -32,8 +32,11 @@ _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,
/*[clinic end generated code: output=02fd19ddaab36602 input=24715a74be15296a]*/
{
double
q
,
num
,
den
,
r
,
x
;
if
(
p
<=
0
.
0
||
p
>=
1
.
0
||
sigma
<=
0
.
0
)
{
goto
error
;
}
q
=
p
-
0
.
5
;
// Algorithm AS 241: The Percentage Points of the Normal Distribution
if
(
fabs
(
q
)
<=
0
.
425
)
{
r
=
0
.
180625
-
q
*
q
;
// Hash sum-55.8831928806149014439
...
...
@@ -53,10 +56,16 @@ _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,
6.8718700749205790830e+2
)
*
r
+
4.2313330701600911252e+1
)
*
r
+
1
.
0
);
if
(
den
==
0
.
0
)
{
goto
error
;
}
x
=
num
/
den
;
return
mu
+
(
x
*
sigma
);
}
r
=
(
q
<=
0
.
0
)
?
p
:
(
1
.
0
-
p
);
if
(
r
<=
0
.
0
||
r
>=
1
.
0
)
{
goto
error
;
}
r
=
sqrt
(
-
log
(
r
));
if
(
r
<=
5
.
0
)
{
r
=
r
-
1
.
6
;
...
...
@@ -97,11 +106,18 @@ _statistics__normal_dist_inv_cdf_impl(PyObject *module, double p, double mu,
5.99832206555887937690e-1
)
*
r
+
1
.
0
);
}
if
(
den
==
0
.
0
)
{
goto
error
;
}
x
=
num
/
den
;
if
(
q
<
0
.
0
)
{
x
=
-
x
;
}
return
mu
+
(
x
*
sigma
);
error:
PyErr_SetString
(
PyExc_ValueError
,
"inv_cdf undefined for these parameters"
);
return
-
1
.
0
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment