Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
6ea29c5e
Commit
6ea29c5e
authored
Sep 25, 2018
by
Victor Stinner
Committed by
Yury Selivanov
Sep 25, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bpo-34687: Make asynico use ProactorEventLoop by default (GH-9538)
parent
c8c0249c
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
30 additions
and
14 deletions
+30
-14
Doc/library/asyncio-platforms.rst
Doc/library/asyncio-platforms.rst
+6
-10
Doc/library/asyncio-policy.rst
Doc/library/asyncio-policy.rst
+13
-1
Doc/whatsnew/3.8.rst
Doc/whatsnew/3.8.rst
+5
-0
Lib/asyncio/windows_events.py
Lib/asyncio/windows_events.py
+1
-1
Lib/test/test_asyncio/test_base_events.py
Lib/test/test_asyncio/test_base_events.py
+1
-1
Lib/test/test_asyncio/test_streams.py
Lib/test/test_asyncio/test_streams.py
+2
-1
Misc/NEWS.d/next/Library/2018-09-24-17-14-57.bpo-34687.Fku_8S.rst
...S.d/next/Library/2018-09-24-17-14-57.bpo-34687.Fku_8S.rst
+2
-0
No files found.
Doc/library/asyncio-platforms.rst
View file @
6ea29c5e
...
@@ -23,6 +23,10 @@ All Platforms
...
@@ -23,6 +23,10 @@ All Platforms
Windows
Windows
=======
=======
.. versionchanged:: 3.8
On Windows, :class:`ProactorEventLoop` is now the default event loop.
All event loops on Windows do not support the following methods:
All event loops on Windows do not support the following methods:
* :meth:`loop.create_unix_connection` and
* :meth:`loop.create_unix_connection` and
...
@@ -67,16 +71,8 @@ Windows configuration.
...
@@ -67,16 +71,8 @@ Windows configuration.
Subprocess Support on Windows
Subprocess Support on Windows
-----------------------------
-----------------------------
:class:`SelectorEventLoop` on Windows does not support subproceses.
On Windows, the default event loop :class:`ProactorEventLoop` supports
On Windows, :class:`ProactorEventLoop` should be used instead::
subprocesses, whereas :class:`SelectorEventLoop` does not.
import asyncio
asyncio.set_event_loop_policy(
asyncio.WindowsProactorEventLoopPolicy())
asyncio.run(your_code())
The :meth:`policy.set_child_watcher()
The :meth:`policy.set_child_watcher()
<AbstractEventLoopPolicy.set_child_watcher>` function is also
<AbstractEventLoopPolicy.set_child_watcher>` function is also
...
...
Doc/library/asyncio-policy.rst
View file @
6ea29c5e
...
@@ -92,11 +92,23 @@ asyncio ships with the following built-in policies:
...
@@ -92,11 +92,23 @@ asyncio ships with the following built-in policies:
.. class:: DefaultEventLoopPolicy
.. class:: DefaultEventLoopPolicy
The default asyncio policy. Uses :class:`SelectorEventLoop`
The default asyncio policy. Uses :class:`SelectorEventLoop`
on
both Unix and Windows platform
s.
on
Unix and :class:`ProactorEventLoop` on Window
s.
There is no need to install the default policy manually. asyncio
There is no need to install the default policy manually. asyncio
is configured to use the default policy automatically.
is configured to use the default policy automatically.
.. versionchanged:: 3.8
On Windows, :class:`ProactorEventLoop` is now used by default.
.. class:: WindowsSelectorEventLoopPolicy
An alternative event loop policy that uses the
:class:`SelectorEventLoop` event loop implementation.
Availability: Windows.
.. class:: WindowsProactorEventLoopPolicy
.. class:: WindowsProactorEventLoopPolicy
...
...
Doc/whatsnew/3.8.rst
View file @
6ea29c5e
...
@@ -116,6 +116,11 @@ New Modules
...
@@ -116,6 +116,11 @@ New Modules
Improved Modules
Improved Modules
================
================
asyncio
-------
On Windows, the default event loop is now :class:`~asyncio.ProactorEventLoop`.
os.path
os.path
-------
-------
...
...
Lib/asyncio/windows_events.py
View file @
6ea29c5e
...
@@ -811,4 +811,4 @@ class WindowsProactorEventLoopPolicy(events.BaseDefaultEventLoopPolicy):
...
@@ -811,4 +811,4 @@ class WindowsProactorEventLoopPolicy(events.BaseDefaultEventLoopPolicy):
_loop_factory
=
ProactorEventLoop
_loop_factory
=
ProactorEventLoop
DefaultEventLoopPolicy
=
Windows
Sele
ctorEventLoopPolicy
DefaultEventLoopPolicy
=
Windows
Proa
ctorEventLoopPolicy
Lib/test/test_asyncio/test_base_events.py
View file @
6ea29c5e
...
@@ -1014,7 +1014,7 @@ class BaseEventLoopWithSelectorTests(test_utils.TestCase):
...
@@ -1014,7 +1014,7 @@ class BaseEventLoopWithSelectorTests(test_utils.TestCase):
def
setUp
(
self
):
def
setUp
(
self
):
super
().
setUp
()
super
().
setUp
()
self
.
loop
=
asyncio
.
new_event_l
oop
()
self
.
loop
=
asyncio
.
SelectorEventL
oop
()
self
.
set_event_loop
(
self
.
loop
)
self
.
set_event_loop
(
self
.
loop
)
@
mock
.
patch
(
'socket.getnameinfo'
)
@
mock
.
patch
(
'socket.getnameinfo'
)
...
...
Lib/test/test_asyncio/test_streams.py
View file @
6ea29c5e
...
@@ -816,7 +816,8 @@ os.close(fd)
...
@@ -816,7 +816,8 @@ os.close(fd)
addr
=
q
.
get
()
addr
=
q
.
get
()
# Should not be stuck in an infinite loop.
# Should not be stuck in an infinite loop.
with
self
.
assertRaises
((
ConnectionResetError
,
BrokenPipeError
)):
with
self
.
assertRaises
((
ConnectionResetError
,
ConnectionAbortedError
,
BrokenPipeError
)):
self
.
loop
.
run_until_complete
(
client
(
*
addr
))
self
.
loop
.
run_until_complete
(
client
(
*
addr
))
# Clean up the thread. (Only on success; on failure, it may
# Clean up the thread. (Only on success; on failure, it may
...
...
Misc/NEWS.d/next/Library/2018-09-24-17-14-57.bpo-34687.Fku_8S.rst
0 → 100644
View file @
6ea29c5e
On Windows, asyncio now uses ProactorEventLoop, instead of
SelectorEventLoop, by default.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment