Commit 7096760b authored by Neal Norwitz's avatar Neal Norwitz

Get rid of xreadlines() (methods).

parent 7c307243
...@@ -79,15 +79,6 @@ Return a list of lines read. The optional \var{size} argument, if given, ...@@ -79,15 +79,6 @@ Return a list of lines read. The optional \var{size} argument, if given,
is an approximate bound on the total number of bytes in the lines returned. is an approximate bound on the total number of bytes in the lines returned.
\end{methoddesc} \end{methoddesc}
\begin{methoddesc}[BZ2File]{xreadlines}{}
For backward compatibility. \class{BZ2File} objects now include the
performance optimizations previously implemented in the
\module{xreadlines} module.
\deprecated{2.3}{This exists only for compatibility with the method by
this name on \class{file} objects, which is
deprecated. Use \code{for line in file} instead.}
\end{methoddesc}
\begin{methoddesc}[BZ2File]{seek}{offset\optional{, whence}} \begin{methoddesc}[BZ2File]{seek}{offset\optional{, whence}}
Move to new file position. Argument \var{offset} is a byte count. Optional Move to new file position. Argument \var{offset} is a byte count. Optional
argument \var{whence} defaults to \code{0} (offset from start of file, argument \var{whence} defaults to \code{0} (offset from start of file,
......
...@@ -1583,12 +1583,6 @@ flush the read-ahead buffer. ...@@ -1583,12 +1583,6 @@ flush the read-ahead buffer.
implemented, or cannot be implemented efficiently. implemented, or cannot be implemented efficiently.
\end{methoddesc} \end{methoddesc}
\begin{methoddesc}[file]{xreadlines}{}
This method returns the same thing as \code{iter(f)}.
\versionadded{2.1}
\deprecated{2.3}{Use \samp{for \var{line} in \var{file}} instead.}
\end{methoddesc}
\begin{methoddesc}[file]{seek}{offset\optional{, whence}} \begin{methoddesc}[file]{seek}{offset\optional{, whence}}
Set the file's current position, like \code{stdio}'s \cfunction{fseek()}. Set the file's current position, like \code{stdio}'s \cfunction{fseek()}.
The \var{whence} argument is optional and defaults to \code{0} The \var{whence} argument is optional and defaults to \code{0}
......
...@@ -50,7 +50,7 @@ import os, glob, re, sys ...@@ -50,7 +50,7 @@ import os, glob, re, sys
def findnames(file, prefixes=()): def findnames(file, prefixes=()):
names = {} names = {}
for line in file.xreadlines(): for line in file:
if line[0] == '!': if line[0] == '!':
continue continue
fields = line.split() fields = line.split()
......
...@@ -29,7 +29,7 @@ __all__ = ["RExec"] ...@@ -29,7 +29,7 @@ __all__ = ["RExec"]
class FileBase: class FileBase:
ok_file_methods = ('fileno', 'flush', 'isatty', 'read', 'readline', ok_file_methods = ('fileno', 'flush', 'isatty', 'read', 'readline',
'readlines', 'seek', 'tell', 'write', 'writelines', 'xreadlines', 'readlines', 'seek', 'tell', 'write', 'writelines',
'__iter__') '__iter__')
......
...@@ -110,14 +110,6 @@ class BZ2FileTest(BaseTest): ...@@ -110,14 +110,6 @@ class BZ2FileTest(BaseTest):
self.assertEqual(list(iter(bz2f)), sio.readlines()) self.assertEqual(list(iter(bz2f)), sio.readlines())
bz2f.close() bz2f.close()
def testXReadLines(self):
# "Test BZ2File.xreadlines()"
self.createTempFile()
bz2f = BZ2File(self.filename)
sio = StringIO(self.TEXT)
self.assertEqual(list(bz2f.xreadlines()), sio.readlines())
bz2f.close()
def testUniversalNewlinesLF(self): def testUniversalNewlinesLF(self):
# "Test BZ2File.read() with universal newlines (\\n)" # "Test BZ2File.read() with universal newlines (\\n)"
self.createTempFile() self.createTempFile()
...@@ -256,7 +248,7 @@ class BZ2FileTest(BaseTest): ...@@ -256,7 +248,7 @@ class BZ2FileTest(BaseTest):
bz2f.close() bz2f.close()
self.assertEqual(lines, ['Test']) self.assertEqual(lines, ['Test'])
bz2f = BZ2File(self.filename) bz2f = BZ2File(self.filename)
xlines = list(bz2f.xreadlines()) xlines = list(bz2f.readlines())
bz2f.close() bz2f.close()
self.assertEqual(lines, ['Test']) self.assertEqual(lines, ['Test'])
......
...@@ -132,7 +132,7 @@ class DecimalTest(unittest.TestCase): ...@@ -132,7 +132,7 @@ class DecimalTest(unittest.TestCase):
if skip_expected: if skip_expected:
raise TestSkipped raise TestSkipped
return return
for line in open(file).xreadlines(): for line in open(file):
line = line.replace('\r\n', '').replace('\n', '') line = line.replace('\r\n', '').replace('\n', '')
#print line #print line
try: try:
......
...@@ -179,7 +179,7 @@ for s in (-1, 0, 1, 512): ...@@ -179,7 +179,7 @@ for s in (-1, 0, 1, 512):
methods = ['fileno', 'flush', 'isatty', 'next', 'read', 'readinto', methods = ['fileno', 'flush', 'isatty', 'next', 'read', 'readinto',
'readline', 'readlines', 'seek', 'tell', 'truncate', 'write', 'readline', 'readlines', 'seek', 'tell', 'truncate', 'write',
'xreadlines', '__iter__'] '__iter__']
if sys.platform.startswith('atheos'): if sys.platform.startswith('atheos'):
methods.remove('truncate') methods.remove('truncate')
......
...@@ -152,7 +152,7 @@ expressed in spaces. Issue an error when the option is given twice. ...@@ -152,7 +152,7 @@ expressed in spaces. Issue an error when the option is given twice.
.B \-u .B \-u
Force stdin, stdout and stderr to be totally unbuffered. On systems Force stdin, stdout and stderr to be totally unbuffered. On systems
where it matters, also put stdin, stdout and stderr in binary mode. where it matters, also put stdin, stdout and stderr in binary mode.
Note that there is internal buffering in xreadlines(), readlines() and Note that there is internal buffering in readlines() and
file-object iterators ("for line in sys.stdin") which is not file-object iterators ("for line in sys.stdin") which is not
influenced by this option. To work around this, you will want to use influenced by this option. To work around this, you will want to use
"sys.stdin.readline()" inside a "while 1:" loop. "sys.stdin.readline()" inside a "while 1:" loop.
......
...@@ -778,13 +778,6 @@ BZ2File_readlines(BZ2FileObject *self, PyObject *args) ...@@ -778,13 +778,6 @@ BZ2File_readlines(BZ2FileObject *self, PyObject *args)
return list; return list;
} }
PyDoc_STRVAR(BZ2File_xreadlines__doc__,
"xreadlines() -> self\n\
\n\
For backward compatibility. BZ2File objects now include the performance\n\
optimizations previously implemented in the xreadlines module.\n\
");
PyDoc_STRVAR(BZ2File_write__doc__, PyDoc_STRVAR(BZ2File_write__doc__,
"write(data) -> None\n\ "write(data) -> None\n\
\n\ \n\
...@@ -1183,7 +1176,6 @@ static PyMethodDef BZ2File_methods[] = { ...@@ -1183,7 +1176,6 @@ static PyMethodDef BZ2File_methods[] = {
{"read", (PyCFunction)BZ2File_read, METH_VARARGS, BZ2File_read__doc__}, {"read", (PyCFunction)BZ2File_read, METH_VARARGS, BZ2File_read__doc__},
{"readline", (PyCFunction)BZ2File_readline, METH_VARARGS, BZ2File_readline__doc__}, {"readline", (PyCFunction)BZ2File_readline, METH_VARARGS, BZ2File_readline__doc__},
{"readlines", (PyCFunction)BZ2File_readlines, METH_VARARGS, BZ2File_readlines__doc__}, {"readlines", (PyCFunction)BZ2File_readlines, METH_VARARGS, BZ2File_readlines__doc__},
{"xreadlines", (PyCFunction)BZ2File_getiter, METH_VARARGS, BZ2File_xreadlines__doc__},
{"write", (PyCFunction)BZ2File_write, METH_VARARGS, BZ2File_write__doc__}, {"write", (PyCFunction)BZ2File_write, METH_VARARGS, BZ2File_write__doc__},
{"writelines", (PyCFunction)BZ2File_writelines, METH_O, BZ2File_writelines__doc__}, {"writelines", (PyCFunction)BZ2File_writelines, METH_O, BZ2File_writelines__doc__},
{"seek", (PyCFunction)BZ2File_seek, METH_VARARGS, BZ2File_seek__doc__}, {"seek", (PyCFunction)BZ2File_seek, METH_VARARGS, BZ2File_seek__doc__},
......
...@@ -1675,12 +1675,6 @@ PyDoc_STRVAR(readlines_doc, ...@@ -1675,12 +1675,6 @@ PyDoc_STRVAR(readlines_doc,
"The optional size argument, if given, is an approximate bound on the\n" "The optional size argument, if given, is an approximate bound on the\n"
"total number of bytes in the lines returned."); "total number of bytes in the lines returned.");
PyDoc_STRVAR(xreadlines_doc,
"xreadlines() -> returns self.\n"
"\n"
"For backward compatibility. File objects now include the performance\n"
"optimizations previously implemented in the xreadlines module.");
PyDoc_STRVAR(writelines_doc, PyDoc_STRVAR(writelines_doc,
"writelines(sequence_of_strings) -> None. Write the strings to the file.\n" "writelines(sequence_of_strings) -> None. Write the strings to the file.\n"
"\n" "\n"
...@@ -1719,7 +1713,6 @@ static PyMethodDef file_methods[] = { ...@@ -1719,7 +1713,6 @@ static PyMethodDef file_methods[] = {
{"tell", (PyCFunction)file_tell, METH_NOARGS, tell_doc}, {"tell", (PyCFunction)file_tell, METH_NOARGS, tell_doc},
{"readinto", (PyCFunction)file_readinto, METH_VARARGS, readinto_doc}, {"readinto", (PyCFunction)file_readinto, METH_VARARGS, readinto_doc},
{"readlines", (PyCFunction)file_readlines,METH_VARARGS, readlines_doc}, {"readlines", (PyCFunction)file_readlines,METH_VARARGS, readlines_doc},
{"xreadlines",(PyCFunction)file_self, METH_NOARGS, xreadlines_doc},
{"writelines",(PyCFunction)file_writelines, METH_O, writelines_doc}, {"writelines",(PyCFunction)file_writelines, METH_O, writelines_doc},
{"flush", (PyCFunction)file_flush, METH_NOARGS, flush_doc}, {"flush", (PyCFunction)file_flush, METH_NOARGS, flush_doc},
{"close", (PyCFunction)file_close, METH_NOARGS, close_doc}, {"close", (PyCFunction)file_close, METH_NOARGS, close_doc},
......
...@@ -504,9 +504,9 @@ Cray T3E: Mark Hadfield (m.hadfield@niwa.co.nz) writes: ...@@ -504,9 +504,9 @@ Cray T3E: Mark Hadfield (m.hadfield@niwa.co.nz) writes:
_codecs, _locale, _socket, _symtable, _testcapi, _weakref _codecs, _locale, _socket, _symtable, _testcapi, _weakref
array, binascii, cmath, cPickle, crypt, cStringIO, dbm array, binascii, cmath, cPickle, crypt, cStringIO, dbm
errno, fcntl, grp, math, md5, operator, parser, pcre, pwd errno, fcntl, grp, math, md5, operator, parser, pwd
regex, rotor, select, struct, strop, syslog, termios rotor, select, struct, strop, syslog, termios,
time, timing, xreadlines time, timing
4) Once the python executable and library have been built, make 4) Once the python executable and library have been built, make
will execute setup.py, which will attempt to build remaining will execute setup.py, which will attempt to build remaining
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment