Commit 70d0ddab authored by Guido van Rossum's avatar Guido van Rossum

Make test_urllib be strict about str/bytes.

(One change to httplib.py, but not enough for test_httplib.)
parent 7436a063
...@@ -373,7 +373,7 @@ class HTTPResponse: ...@@ -373,7 +373,7 @@ class HTTPResponse:
# Assume it's a Simple-Response from an 0.9 server. # Assume it's a Simple-Response from an 0.9 server.
# We have to convert the first line back to raw bytes # We have to convert the first line back to raw bytes
# because self.fp.readline() needs to return bytes. # because self.fp.readline() needs to return bytes.
self.fp = LineAndFileWrapper(bytes(line), self.fp) self.fp = LineAndFileWrapper(bytes(line, "ascii"), self.fp)
return "HTTP/0.9", 200, "" return "HTTP/0.9", 200, ""
# The status code is a three-digit number # The status code is a three-digit number
......
...@@ -30,7 +30,7 @@ class urlopen_FileTests(unittest.TestCase): ...@@ -30,7 +30,7 @@ class urlopen_FileTests(unittest.TestCase):
def setUp(self): def setUp(self):
"""Setup of a temp file to use for testing""" """Setup of a temp file to use for testing"""
self.text = bytes("test_urllib: %s\n" % self.__class__.__name__) self.text = bytes("test_urllib: %s\n" % self.__class__.__name__, "ascii")
FILE = open(test_support.TESTFN, 'wb') FILE = open(test_support.TESTFN, 'wb')
try: try:
FILE.write(self.text) FILE.write(self.text)
...@@ -168,7 +168,7 @@ class urlretrieve_FileTests(unittest.TestCase): ...@@ -168,7 +168,7 @@ class urlretrieve_FileTests(unittest.TestCase):
def constructLocalFileUrl(self, filePath): def constructLocalFileUrl(self, filePath):
return "file://%s" % urllib.pathname2url(os.path.abspath(filePath)) return "file://%s" % urllib.pathname2url(os.path.abspath(filePath))
def createNewTempFile(self, data=""): def createNewTempFile(self, data=b""):
"""Creates a new temporary file containing the specified data, """Creates a new temporary file containing the specified data,
registers the file for deletion during the test fixture tear down, and registers the file for deletion during the test fixture tear down, and
returns the absolute path of the file.""" returns the absolute path of the file."""
...@@ -246,7 +246,7 @@ class urlretrieve_FileTests(unittest.TestCase): ...@@ -246,7 +246,7 @@ class urlretrieve_FileTests(unittest.TestCase):
report = [] report = []
def hooktester(count, block_size, total_size, _report=report): def hooktester(count, block_size, total_size, _report=report):
_report.append((count, block_size, total_size)) _report.append((count, block_size, total_size))
srcFileName = self.createNewTempFile("x" * 5) srcFileName = self.createNewTempFile(b"x" * 5)
urllib.urlretrieve(self.constructLocalFileUrl(srcFileName), urllib.urlretrieve(self.constructLocalFileUrl(srcFileName),
test_support.TESTFN, hooktester) test_support.TESTFN, hooktester)
self.assertEqual(len(report), 2) self.assertEqual(len(report), 2)
...@@ -260,7 +260,7 @@ class urlretrieve_FileTests(unittest.TestCase): ...@@ -260,7 +260,7 @@ class urlretrieve_FileTests(unittest.TestCase):
report = [] report = []
def hooktester(count, block_size, total_size, _report=report): def hooktester(count, block_size, total_size, _report=report):
_report.append((count, block_size, total_size)) _report.append((count, block_size, total_size))
srcFileName = self.createNewTempFile("x" * 8193) srcFileName = self.createNewTempFile(b"x" * 8193)
urllib.urlretrieve(self.constructLocalFileUrl(srcFileName), urllib.urlretrieve(self.constructLocalFileUrl(srcFileName),
test_support.TESTFN, hooktester) test_support.TESTFN, hooktester)
self.assertEqual(len(report), 3) self.assertEqual(len(report), 3)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment