Commit 738cc741 authored by Antoine Pitrou's avatar Antoine Pitrou

Issue #23629: Fix the default __sizeof__ implementation for variable-sized objects.

parent 9561597c
...@@ -10,6 +10,9 @@ What's New in Python 2.7.10? ...@@ -10,6 +10,9 @@ What's New in Python 2.7.10?
Core and Builtins Core and Builtins
----------------- -----------------
- Issue #23629: Fix the default __sizeof__ implementation for variable-sized
objects.
- Issue #23055: Fixed a buffer overflow in PyUnicode_FromFormatV. Analysis - Issue #23055: Fixed a buffer overflow in PyUnicode_FromFormatV. Analysis
and fix by Guido Vranken. and fix by Guido Vranken.
......
...@@ -761,27 +761,15 @@ tuple_getnewargs(PyTupleObject *v) ...@@ -761,27 +761,15 @@ tuple_getnewargs(PyTupleObject *v)
} }
static PyObject *
tuple_sizeof(PyTupleObject *self)
{
Py_ssize_t res;
res = PyTuple_Type.tp_basicsize + Py_SIZE(self) * sizeof(PyObject *);
return PyInt_FromSsize_t(res);
}
PyDoc_STRVAR(index_doc, PyDoc_STRVAR(index_doc,
"T.index(value, [start, [stop]]) -> integer -- return first index of value.\n" "T.index(value, [start, [stop]]) -> integer -- return first index of value.\n"
"Raises ValueError if the value is not present." "Raises ValueError if the value is not present."
); );
PyDoc_STRVAR(count_doc, PyDoc_STRVAR(count_doc,
"T.count(value) -> integer -- return number of occurrences of value"); "T.count(value) -> integer -- return number of occurrences of value");
PyDoc_STRVAR(sizeof_doc,
"T.__sizeof__() -- size of T in memory, in bytes");
static PyMethodDef tuple_methods[] = { static PyMethodDef tuple_methods[] = {
{"__getnewargs__", (PyCFunction)tuple_getnewargs, METH_NOARGS}, {"__getnewargs__", (PyCFunction)tuple_getnewargs, METH_NOARGS},
{"__sizeof__", (PyCFunction)tuple_sizeof, METH_NOARGS, sizeof_doc},
{"index", (PyCFunction)tupleindex, METH_VARARGS, index_doc}, {"index", (PyCFunction)tupleindex, METH_VARARGS, index_doc},
{"count", (PyCFunction)tuplecount, METH_O, count_doc}, {"count", (PyCFunction)tuplecount, METH_O, count_doc},
{NULL, NULL} /* sentinel */ {NULL, NULL} /* sentinel */
......
...@@ -3507,7 +3507,7 @@ object_sizeof(PyObject *self, PyObject *args) ...@@ -3507,7 +3507,7 @@ object_sizeof(PyObject *self, PyObject *args)
res = 0; res = 0;
isize = self->ob_type->tp_itemsize; isize = self->ob_type->tp_itemsize;
if (isize > 0) if (isize > 0)
res = self->ob_type->ob_size * isize; res = Py_SIZE(self) * isize;
res += self->ob_type->tp_basicsize; res += self->ob_type->tp_basicsize;
return PyInt_FromSsize_t(res); return PyInt_FromSsize_t(res);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment