Add missing check of PyDict_SetItem()'s return value in _PyImport_FindExtensionObject()

CID 486649

Add missing check of PyDict_SetItem()'s return value in _PyImport_FindExtensionObject()
CID 486649
74ba26a4 · Christian Heimes · 895bdfb1 · 09ca794a · 74ba26a4
Commit 74ba26a4 authored Jul 20, 2013 by Christian Heimes
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 1 deletion

Python/import.c Python/import.c +4 -1

No files found.
--- a/Python/import.c
+++ b/Python/import.c
@@ -585,7 +585,10 @@ _PyImport_FindExtensionObject(PyObject *name, PyObject *filename)
        mod = def->m_base.m_init();
        if (mod == NULL)
            return NULL;
-        PyDict_SetItem(PyImport_GetModuleDict(), name, mod);
+        if (PyDict_SetItem(PyImport_GetModuleDict(), name, mod) == -1) {
+            Py_DECREF(mod);
+            return NULL;
+        }
        Py_DECREF(mod);
    }
    if (_PyState_AddModule(mod, def) < 0) {