Correct overflow check in PyTuple_New() (GH-14838)

755d4ef8 · Sergey Fedoseev · T. Wouters · 832e8640 · 755d4ef8
Commit 755d4ef8 authored Sep 10, 2019 by Sergey Fedoseev Committed by T. Wouters Sep 09, 2019
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 2 deletions

Objects/tupleobject.c Objects/tupleobject.c +2 -2

No files found.
--- a/Objects/tupleobject.c
+++ b/Objects/tupleobject.c
@@ -120,8 +120,8 @@ tuple_alloc(Py_ssize_t size)
 #endif
    {
        /* Check for overflow */
-        if ((size_t)size > ((size_t)PY_SSIZE_T_MAX - sizeof(PyTupleObject) -
+        if ((size_t)size > ((size_t)PY_SSIZE_T_MAX - (sizeof(PyTupleObject) -
-                    sizeof(PyObject *)) / sizeof(PyObject *)) {
+                    sizeof(PyObject *))) / sizeof(PyObject *)) {
            return (PyTupleObject *)PyErr_NoMemory();
        }
        op = PyObject_GC_NewVar(PyTupleObject, &PyTuple_Type, size);