Commit 774f9094 authored by Gregory P. Smith's avatar Gregory P. Smith

Fixes issue #19506: Use a memoryview to avoid a data copy when piping data

to stdin within subprocess.Popen.communicate.  5-10% less cpu usage.
parent 6c527cf3
...@@ -1621,6 +1621,9 @@ class Popen(object): ...@@ -1621,6 +1621,9 @@ class Popen(object):
self._save_input(input) self._save_input(input)
if self._input:
input_view = memoryview(self._input)
while self._fd2file: while self._fd2file:
timeout = self._remaining_time(endtime) timeout = self._remaining_time(endtime)
if timeout is not None and timeout < 0: if timeout is not None and timeout < 0:
...@@ -1638,8 +1641,8 @@ class Popen(object): ...@@ -1638,8 +1641,8 @@ class Popen(object):
for fd, mode in ready: for fd, mode in ready:
if mode & select.POLLOUT: if mode & select.POLLOUT:
chunk = self._input[self._input_offset : chunk = input_view[self._input_offset :
self._input_offset + _PIPE_BUF] self._input_offset + _PIPE_BUF]
try: try:
self._input_offset += os.write(fd, chunk) self._input_offset += os.write(fd, chunk)
except OSError as e: except OSError as e:
......
...@@ -18,6 +18,9 @@ Core and Builtins ...@@ -18,6 +18,9 @@ Core and Builtins
Library Library
------- -------
- Issue #19506: Use a memoryview to avoid a data copy when piping data
to stdin within subprocess.Popen.communicate. 5-10% less cpu usage.
- Issue #19839: Fix regression in bz2 module's handling of non-bzip2 data at - Issue #19839: Fix regression in bz2 module's handling of non-bzip2 data at
EOF, and analogous bug in lzma module. EOF, and analogous bug in lzma module.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment