Commit 7e87193f authored by Serhiy Storchaka's avatar Serhiy Storchaka

Fix reference leaks introduced by the patch for issue #5308.

parent b6234425
...@@ -95,7 +95,7 @@ w_more(int c, WFILE *p) ...@@ -95,7 +95,7 @@ w_more(int c, WFILE *p)
} }
static void static void
w_string(char *s, Py_ssize_t n, WFILE *p) w_string(const char *s, Py_ssize_t n, WFILE *p)
{ {
if (p->fp != NULL) { if (p->fp != NULL) {
fwrite(s, 1, n, p->fp); fwrite(s, 1, n, p->fp);
...@@ -139,6 +139,13 @@ w_long(long x, WFILE *p) ...@@ -139,6 +139,13 @@ w_long(long x, WFILE *p)
# define W_SIZE w_long # define W_SIZE w_long
#endif #endif
static void
w_pstring(const char *s, Py_ssize_t n, WFILE *p)
{
W_SIZE(n, p);
w_string(s, n, p);
}
/* We assume that Python longs are stored internally in base some power of /* We assume that Python longs are stored internally in base some power of
2**15; for the sake of portability we'll always read and write them in base 2**15; for the sake of portability we'll always read and write them in base
exactly 2**15. */ exactly 2**15. */
...@@ -313,9 +320,7 @@ w_object(PyObject *v, WFILE *p) ...@@ -313,9 +320,7 @@ w_object(PyObject *v, WFILE *p)
} }
else if (PyBytes_CheckExact(v)) { else if (PyBytes_CheckExact(v)) {
w_byte(TYPE_STRING, p); w_byte(TYPE_STRING, p);
n = PyBytes_GET_SIZE(v); w_pstring(PyBytes_AS_STRING(v), PyBytes_GET_SIZE(v), p);
W_SIZE(n, p);
w_string(PyBytes_AS_STRING(v), n, p);
} }
else if (PyUnicode_CheckExact(v)) { else if (PyUnicode_CheckExact(v)) {
PyObject *utf8; PyObject *utf8;
...@@ -326,9 +331,7 @@ w_object(PyObject *v, WFILE *p) ...@@ -326,9 +331,7 @@ w_object(PyObject *v, WFILE *p)
return; return;
} }
w_byte(TYPE_UNICODE, p); w_byte(TYPE_UNICODE, p);
n = PyBytes_GET_SIZE(utf8); w_pstring(PyBytes_AS_STRING(utf8), PyBytes_GET_SIZE(utf8), p);
W_SIZE(n, p);
w_string(PyBytes_AS_STRING(utf8), n, p);
Py_DECREF(utf8); Py_DECREF(utf8);
} }
else if (PyTuple_CheckExact(v)) { else if (PyTuple_CheckExact(v)) {
...@@ -411,7 +414,6 @@ w_object(PyObject *v, WFILE *p) ...@@ -411,7 +414,6 @@ w_object(PyObject *v, WFILE *p)
} }
else if (PyObject_CheckBuffer(v)) { else if (PyObject_CheckBuffer(v)) {
/* Write unknown buffer-style objects as a string */ /* Write unknown buffer-style objects as a string */
char *s;
Py_buffer view; Py_buffer view;
if (PyObject_GetBuffer(v, &view, PyBUF_SIMPLE) != 0) { if (PyObject_GetBuffer(v, &view, PyBUF_SIMPLE) != 0) {
w_byte(TYPE_UNKNOWN, p); w_byte(TYPE_UNKNOWN, p);
...@@ -420,10 +422,7 @@ w_object(PyObject *v, WFILE *p) ...@@ -420,10 +422,7 @@ w_object(PyObject *v, WFILE *p)
return; return;
} }
w_byte(TYPE_STRING, p); w_byte(TYPE_STRING, p);
n = view.len; w_pstring(view.buf, view.len, p);
s = view.buf;
W_SIZE(n, p);
w_string(s, n, p);
PyBuffer_Release(&view); PyBuffer_Release(&view);
} }
else { else {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment