Add missing check of PyDict_Update()'s return value in _elementtree.c

CID 719637

Add missing check of PyDict_Update()'s return value in _elementtree.c
CID 719637
7ed4294d · Christian Heimes · 97cb67b9 · 7ed4294d
Commit 7ed4294d authored Jul 20, 2013 by Christian Heimes
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 1 deletion

Modules/_elementtree.c Modules/_elementtree.c +2 -1

No files found.
--- a/Modules/_elementtree.c
+++ b/Modules/_elementtree.c
@@ -347,7 +347,8 @@ get_attrib_from_keywords(PyObject *kwds)
    Py_DECREF(attrib_str);

    if (attrib)
-        PyDict_Update(attrib, kwds);
+        if (PyDict_Update(attrib, kwds) < 0)
+            return NULL;
    return attrib;
 }