add missing NULL check

7fc8a105 · Benjamin Peterson · 5c863bf9 · 7fc8a105
Commit 7fc8a105 authored Apr 14, 2014 by Benjamin Peterson
Hide whitespace changes
Inline Side-by-side

Showing with 9 additions and 5 deletions

Modules/posixmodule.c Modules/posixmodule.c +9 -5

No files found.
--- a/Modules/posixmodule.c
+++ b/Modules/posixmodule.c
@@ -6856,13 +6856,17 @@ posix_fdopen(PyObject *self, PyObject *args)
 #if defined(HAVE_FSTAT) && defined(S_IFDIR) && defined(EISDIR)
    {
        struct stat buf;
+        const char *msg;
+        PyObject *exc;
        if (fstat(fd, &buf) == 0 && S_ISDIR(buf.st_mode)) {
            PyMem_FREE(mode);
-            char *msg = strerror(EISDIR);
+            msg = strerror(EISDIR);
-            PyObject *exc = PyObject_CallFunction(PyExc_IOError, "(isO)",
+            exc = PyObject_CallFunction(PyExc_IOError, "(isO)",
-                                                  EISDIR, msg, "<fdopen>");
+                                        EISDIR, msg, "<fdopen>");
-            PyErr_SetObject(PyExc_IOError, exc);
+            if (exc) {
-            Py_XDECREF(exc);
+                PyErr_SetObject(PyExc_IOError, exc);
+                Py_DECREF(exc);
+            }
            return NULL;
        }
    }