Commit 80113822 authored by Steve Dower's avatar Steve Dower

Issue #23619: Ensure C variable is initialized before using it.

The garbage in _crtInstalledToken was causing the IsCrtInstalled() function to return TRUE without actually checking anything. We now initialize the variable first.
parent 5d2d63ed
...@@ -2574,6 +2574,7 @@ public: ...@@ -2574,6 +2574,7 @@ public:
} }
} }
_crtInstalledToken = -1;
pEngine->SetVariableNumeric(L"CRTInstalled", IsCrtInstalled() ? 1 : 0); pEngine->SetVariableNumeric(L"CRTInstalled", IsCrtInstalled() ? 1 : 0);
_wixLoc = nullptr; _wixLoc = nullptr;
...@@ -2603,8 +2604,6 @@ public: ...@@ -2603,8 +2604,6 @@ public:
_suppressRepair = FALSE; _suppressRepair = FALSE;
_modifying = FALSE; _modifying = FALSE;
_crtInstalledToken = -1;
_overridableVariables = nullptr; _overridableVariables = nullptr;
_taskbarList = nullptr; _taskbarList = nullptr;
_taskbarButtonCreatedMessage = UINT_MAX; _taskbarButtonCreatedMessage = UINT_MAX;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment