Commit 8052f892 authored by Guido van Rossum's avatar Guido van Rossum

Undo this part of the previous checkin:

  Also fixed an error message -- %s argument has non-string str()
  doesn't make sense for %r, so the error message now differentiates
  between %s and %r.

because PyObject_Repr() and PyObject_Str() ensure that this can never
happen.  Added a helpful comment instead.
parent b00c07f0
......@@ -3874,10 +3874,11 @@ PyString_Format(PyObject *format, PyObject *args)
if (temp == NULL)
goto error;
if (!PyString_Check(temp)) {
/* XXX Note: this should never happen,
since PyObject_Repr() and
PyObject_Str() assure this */
PyErr_SetString(PyExc_TypeError,
c == 's' ?
"%s argument has non-string str()" :
"%r argument has non-string repr()");
"%s argument has non-string str()");
Py_DECREF(temp);
goto error;
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment