Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
83245b58
Commit
83245b58
authored
Mar 12, 2003
by
Raymond Hettinger
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
SF bug #699934: Obscure error message
Clarify error message for mro conflicts.
parent
45c39415
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
11 additions
and
4 deletions
+11
-4
Lib/test/test_descr.py
Lib/test/test_descr.py
+7
-3
Objects/typeobject.c
Objects/typeobject.c
+4
-1
No files found.
Lib/test/test_descr.py
View file @
83245b58
...
...
@@ -1062,6 +1062,10 @@ def consistency_with_epg():
(
EditableScrollablePane
,
ScrollablePane
,
EditablePane
,
Pane
,
ScrollingMixin
,
EditingMixin
,
object
))
mro_err_msg
=
"""Cannot create class.The superclasses have conflicting
inheritance trees which leave the method resolution order (MRO)
undefined for bases """
def
mro_disagreement
():
if
verbose
:
print
"Testing error messages for MRO disagreement..."
def
raises
(
exc
,
expected
,
callable
,
*
args
):
...
...
@@ -1079,9 +1083,9 @@ def mro_disagreement():
# Test some very simple errors
raises
(
TypeError
,
"duplicate base class A"
,
type
,
"X"
,
(
A
,
A
),
{})
raises
(
TypeError
,
"MRO conflict among bases "
,
raises
(
TypeError
,
mro_err_msg
,
type
,
"X"
,
(
A
,
B
),
{})
raises
(
TypeError
,
"MRO conflict among bases "
,
raises
(
TypeError
,
mro_err_msg
,
type
,
"X"
,
(
A
,
C
,
B
),
{})
# Test a slightly more complex error
class
GridLayout
(
object
):
pass
...
...
@@ -1089,7 +1093,7 @@ def mro_disagreement():
class
VerticalGrid
(
GridLayout
):
pass
class
HVGrid
(
HorizontalGrid
,
VerticalGrid
):
pass
class
VHGrid
(
VerticalGrid
,
HorizontalGrid
):
pass
raises
(
TypeError
,
"MRO conflict among bases "
,
raises
(
TypeError
,
mro_err_msg
,
type
,
"ConfusedGrid"
,
(
HVGrid
,
VHGrid
),
{})
def
objects
():
...
...
Objects/typeobject.c
View file @
83245b58
...
...
@@ -1076,7 +1076,10 @@ set_mro_error(PyObject *to_merge, int *remain)
}
n
=
PyDict_Size
(
set
);
off
=
PyOS_snprintf
(
buf
,
sizeof
(
buf
),
"MRO conflict among bases"
);
off
=
PyOS_snprintf
(
buf
,
sizeof
(
buf
),
"Cannot create class.\
The superclasses have conflicting
\n
\
inheritance trees which leave the method resolution order (MRO)
\n
\
undefined for bases"
);
i
=
0
;
while
(
PyDict_Next
(
set
,
&
i
,
&
k
,
&
v
)
&&
off
<
sizeof
(
buf
))
{
PyObject
*
name
=
class_name
(
k
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment