Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cpython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Kirill Smelkov
cpython
Commits
83c1ffec
Commit
83c1ffec
authored
Jan 27, 2008
by
Neal Norwitz
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
socket.error doesn't have a headers attribute like ProtocolError.
Handle that situation where we catch socket.errors.
parent
393edbc7
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
10 deletions
+10
-10
Lib/test/test_xmlrpc.py
Lib/test/test_xmlrpc.py
+10
-10
No files found.
Lib/test/test_xmlrpc.py
View file @
83c1ffec
...
...
@@ -397,7 +397,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
# [ch] The test 404 is causing lots of false alarms.
def
XXXtest_404
(
self
):
...
...
@@ -423,7 +423,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_introspection2
(
self
):
try
:
...
...
@@ -435,7 +435,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_introspection3
(
self
):
try
:
...
...
@@ -447,7 +447,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_introspection4
(
self
):
# the SimpleXMLRPCServer doesn't support signatures, but
...
...
@@ -460,7 +460,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_multicall
(
self
):
try
:
...
...
@@ -477,7 +477,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_non_existing_multicall
(
self
):
try
:
...
...
@@ -498,7 +498,7 @@ class SimpleServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_dotted_attribute
(
self
):
# this will raise AttirebuteError because code don't want us to use
...
...
@@ -553,7 +553,7 @@ class FailingServerTestCase(unittest.TestCase):
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
# protocol error; provide additional information in test output
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
e
.
headers
))
self
.
fail
(
"%s
\
n
%s"
%
(
e
,
getattr
(
e
,
"headers"
,
""
)
))
def
test_fail_no_info
(
self
):
# use the broken message class
...
...
@@ -564,7 +564,7 @@ class FailingServerTestCase(unittest.TestCase):
p
.
pow
(
6
,
8
)
except
(
xmlrpclib
.
ProtocolError
,
socket
.
error
),
e
:
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
if
not
is_unavailable_exception
(
e
)
and
hasattr
(
e
,
"headers"
)
:
# The two server-side error headers shouldn't be sent back in this case
self
.
assertTrue
(
e
.
headers
.
get
(
"X-exception"
)
is
None
)
self
.
assertTrue
(
e
.
headers
.
get
(
"X-traceback"
)
is
None
)
...
...
@@ -584,7 +584,7 @@ class FailingServerTestCase(unittest.TestCase):
p
.
pow
(
6
,
8
)
except
(
xmlrpclib
.
ProtocolError
,
socket
.
error
),
e
:
# ignore failures due to non-blocking socket 'unavailable' errors
if
not
is_unavailable_exception
(
e
):
if
not
is_unavailable_exception
(
e
)
and
hasattr
(
e
,
"headers"
)
:
# We should get error info in the response
expected_err
=
"invalid literal for int() with base 10: 'I am broken'"
self
.
assertEqual
(
e
.
headers
.
get
(
"x-exception"
),
expected_err
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment