Commit 897bba75 authored by Denis Osipov's avatar Denis Osipov Committed by Victor Stinner

bpo-30584: Fix test_os fails on non-English Windows (#1980)

* Fix bpo-30584

* Adding a comment mentionning the bpo and explaining what is the identifier

* Add Denis Osipov to Misc/ACKS
parent add98eb4
...@@ -472,7 +472,9 @@ class StatAttributeTests(unittest.TestCase): ...@@ -472,7 +472,9 @@ class StatAttributeTests(unittest.TestCase):
# force CreateFile to fail with ERROR_ACCESS_DENIED. # force CreateFile to fail with ERROR_ACCESS_DENIED.
DETACHED_PROCESS = 8 DETACHED_PROCESS = 8
subprocess.check_call( subprocess.check_call(
['icacls.exe', fname, '/deny', 'Users:(S)'], # bpo-30584: Use security identifier *S-1-5-32-545 instead
# of localized "Users" to not depend on the locale.
['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'],
creationflags=DETACHED_PROCESS creationflags=DETACHED_PROCESS
) )
result = os.stat(fname) result = os.stat(fname)
......
...@@ -1132,6 +1132,7 @@ William Orr ...@@ -1132,6 +1132,7 @@ William Orr
Michele Orrù Michele Orrù
Tomáš Orsava Tomáš Orsava
Oleg Oshmyan Oleg Oshmyan
Denis Osipov
Denis S. Otkidach Denis S. Otkidach
Peter Otten Peter Otten
Michael Otteneder Michael Otteneder
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment